Skip to content

[release-4.19] OCPBUGS-57901: vSphere - remove unit tests using nip.io #9802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.19
Choose a base branch
from
Open

[release-4.19] OCPBUGS-57901: vSphere - remove unit tests using nip.io #9802

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9793

/assign jcpowermac

@jcpowermac
vSphere - remove unit tests using nip.io
28a4324 
The hex based dns service is no longer available
and the replacement service does not take PRs
or looks interested in this feature.

If we want this unit test in the future we will need
to think through how to implement this.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 20, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-57535 has been cloned as Jira Issue OCPBUGS-57901. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-57901: vSphere - remove unit tests using nip.io

In response to this:

This is an automated cherry-pick of #9793

/assign jcpowermac

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-57535: vSphere - remove unit tests using nip.io [release-4.19] OCPBUGS-57901: vSphere - remove unit tests using nip.io Jun 20, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 20, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-57901, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #9793

/assign jcpowermac

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 20, 2025
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: This pull request references Jira Issue OCPBUGS-57901, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-57535 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-57535 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @sgaoshang

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tthvo
tthvo reviewed Jun 20, 2025
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2025
@jcpowermac
Copy link
Contributor

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link
Author

@jcpowermac: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcpowermac
Copy link
Contributor

@patrickdillon @sadasu can you add the backport-risk-assessed, cherry-pick-approved labels, thanks!

@tthvo
Copy link
Member

tthvo commented Jun 20, 2025

/cc @gpei

@openshift-ci openshift-ci bot requested a review from gpei June 20, 2025 17:29
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 20, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 28a4324 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn 28a4324 link true /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-multi-vcenter-ovn 28a4324 link false /test e2e-vsphere-multi-vcenter-ovn
ci/prow/e2e-vsphere-ovn-zones-techpreview 28a4324 link false /test e2e-vsphere-ovn-zones-techpreview
ci/prow/e2e-vsphere-ovn-multi-network 28a4324 link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-vsphere-ovn-techpreview 28a4324 link false /test e2e-vsphere-ovn-techpreview
ci/prow/e2e-vsphere-externallb-ovn 28a4324 link false /test e2e-vsphere-externallb-ovn
ci/prow/e2e-vsphere-ovn-zones 28a4324 link false /test e2e-vsphere-ovn-zones
ci/prow/e2e-vsphere-ovn-multi-disk 28a4324 link false /test e2e-vsphere-ovn-multi-disk
ci/prow/e2e-vsphere-static-ovn 28a4324 link false /test e2e-vsphere-static-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gpei
Copy link
Contributor

gpei commented Jun 21, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo left review comments

@sgaoshang sgaoshang Awaiting requested review from sgaoshang

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

@gpei gpei Awaiting requested review from gpei

Assignees

@jcpowermac jcpowermac

@tthvo tthvo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @jcpowermac @tthvo @gpei