Skip to content

OCPBUGS-57535: vSphere - remove unit tests using nip.io #9793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

OCPBUGS-57535: vSphere - remove unit tests using nip.io #9793

merged 1 commit into from
Jun 18, 2025

Conversation

jcpowermac
Copy link
Contributor

The hex based dns service is no longer available
and the replacement service does not take PRs
or looks interested in this feature.

If we want this unit test in the future we will need to think through how to implement this.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 17, 2025
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: This pull request references Jira Issue OCPBUGS-57535, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The hex based dns service is no longer available
and the replacement service does not take PRs
or looks interested in this feature.

If we want this unit test in the future we will need to think through how to implement this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 17, 2025
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: This pull request references Jira Issue OCPBUGS-57535, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sgaoshang

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor Author

/assign @patrickdillon

tthvo
tthvo reviewed Jun 17, 2025
View reviewed changes
pkg/asset/installconfig/vsphere/validation_test.go
installConfig: func() *types.InstallConfig {
installConfig := validIPIInstallConfig()
installConfig.ObjectMeta.Name = "0a000803"
installConfig.BaseDomain = wildcardDNS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can remove:

installer/pkg/asset/installconfig/vsphere/validation_test.go

Line 44 in 55b3518

const wildcardDNS = "nip.io"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@jcpowermac
vSphere - remove unit tests using nip.io
343de76 
The hex based dns service is no longer available
and the replacement service does not take PRs
or looks interested in this feature.

If we want this unit test in the future we will need
to think through how to implement this.
tthvo
tthvo reviewed Jun 17, 2025
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 18, 2025

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-externallb-ovn 343de76 link false /test e2e-vsphere-externallb-ovn
ci/prow/e2e-vsphere-ovn-techpreview 343de76 link false /test e2e-vsphere-ovn-techpreview
ci/prow/e2e-vsphere-ovn-hybrid-env 343de76 link false /test e2e-vsphere-ovn-hybrid-env

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vr4manta
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit bc941c8 into openshift:main Jun 18, 2025
22 of 25 checks passed
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: Jira Issue OCPBUGS-57535: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-57535 has been moved to the MODIFIED state.

In response to this:

The hex based dns service is no longer available
and the replacement service does not take PRs
or looks interested in this feature.

If we want this unit test in the future we will need to think through how to implement this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@patrickdillon patrickdillon mentioned this pull request Jun 18, 2025
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer
This PR has been included in build ose-installer-container-v4.20.0-202506181441.p0.gbc941c8.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.20.0-202506181441.p0.gbc941c8.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.20.0-202506181441.p0.gbc941c8.assembly.stream.el9.
All builds following this will include this PR.

@jcpowermac
Copy link
Contributor Author

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link

@jcpowermac: new pull request created: #9802

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo left review comments

@sgaoshang sgaoshang Awaiting requested review from sgaoshang

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@patrickdillon patrickdillon

@tthvo tthvo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jcpowermac @openshift-ci-robot @vr4manta @openshift-bot @openshift-cherrypick-robot @tthvo @patrickdillon