-
Notifications
You must be signed in to change notification settings - Fork 1.4k
OCPBUGS-57000: Revert "CORS-3883: Remove user-assigned identity from ARM template" #9766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-57000: Revert "CORS-3883: Remove user-assigned identity from ARM template" #9766
Conversation
@jinyunma: This pull request references Jira Issue OCPBUGS-57000, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@jinyunma: This pull request references Jira Issue OCPBUGS-57000, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jinyunma. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @patrickdillon |
@jinyunma: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
93d2f03
into
openshift:main
@jinyunma: Jira Issue OCPBUGS-57000: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-57000 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
[ART PR BUILD NOTIFIER] Distgit: ose-installer |
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
/cherry-pick release-4.19 |
@jinyunma: new pull request created: #9771 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Reverts #9625
Based on #9718, installer default behavior is changed back to create user-assigned identity to avoid pulling image from ACR failed.
#9625 removed the user-assigned identity configuration from Azure ARM template, so the issue also happens on UPI cluster.
The Azure ARM template in UPI installation doc is synced from installer repo automatically, #9625 needs to be reverted until installer default behavior changes to use "None" identity type, so that doc has correct ARM template content.