Skip to content

OCPBUGS-57000: Revert "CORS-3883: Remove user-assigned identity from ARM template" #9766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jinyunma
Copy link
Contributor

@jinyunma jinyunma commented Jun 3, 2025

Reverts #9625

Based on #9718, installer default behavior is changed back to create user-assigned identity to avoid pulling image from ACR failed.

#9625 removed the user-assigned identity configuration from Azure ARM template, so the issue also happens on UPI cluster.

The Azure ARM template in UPI installation doc is synced from installer repo automatically, #9625 needs to be reverted until installer default behavior changes to use "None" identity type, so that doc has correct ARM template content.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 3, 2025
@openshift-ci-robot
Copy link
Contributor

@jinyunma: This pull request references Jira Issue OCPBUGS-57000, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #9625

Based on #9718, installer default behavior is changed back to create user-assigned identity to avoid pulling image from ACR failed.

#9625 removed the user-assigned identity configuration from Azure ARM template, so the issue also happens on UPI cluster.

The Azure ARM template in UPI installation doc is synced from installer repo automatically, #9625 needs to be reverted until installer default behavior changes to use "None" identity type, so that doc has correct ARM template content.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhixson74 and sadasu June 3, 2025 09:00
@jinyunma
Copy link
Contributor Author

jinyunma commented Jun 3, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 3, 2025
@openshift-ci-robot
Copy link
Contributor

@jinyunma: This pull request references Jira Issue OCPBUGS-57000, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 3, 2025
Copy link
Contributor

openshift-ci bot commented Jun 3, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jinyunma.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@jinyunma: This pull request references Jira Issue OCPBUGS-57000, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jinyunma
Copy link
Contributor Author

jinyunma commented Jun 3, 2025

/cc @patrickdillon

@openshift-ci openshift-ci bot requested a review from patrickdillon June 3, 2025 09:10
Copy link
Contributor

openshift-ci bot commented Jun 3, 2025

@jinyunma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upi 2e10b84 link false /test e2e-azure-ovn-upi
ci/prow/e2e-azurestack-upi 2e10b84 link false /test e2e-azurestack-upi
ci/prow/okd-scos-e2e-aws-ovn 2e10b84 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-multi-network 2e10b84 link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-azurestack 2e10b84 link false /test e2e-azurestack
ci/prow/azure-ovn-marketplace-images 2e10b84 link false /test azure-ovn-marketplace-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2025
Copy link
Contributor

openshift-ci bot commented Jun 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 93d2f03 into openshift:main Jun 5, 2025
18 of 24 checks passed
@openshift-ci-robot
Copy link
Contributor

@jinyunma: Jira Issue OCPBUGS-57000: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-57000 has been moved to the MODIFIED state.

In response to this:

Reverts #9625

Based on #9718, installer default behavior is changed back to create user-assigned identity to avoid pulling image from ACR failed.

#9625 removed the user-assigned identity configuration from Azure ARM template, so the issue also happens on UPI cluster.

The Azure ARM template in UPI installation doc is synced from installer repo automatically, #9625 needs to be reverted until installer default behavior changes to use "None" identity type, so that doc has correct ARM template content.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jinyunma jinyunma deleted the revert-9625-azure-remove-identity branch June 5, 2025 21:12
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.20.0-202506051942.p0.g93d2f03.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer
This PR has been included in build ose-installer-container-v4.20.0-202506051942.p0.g93d2f03.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.20.0-202506051942.p0.g93d2f03.assembly.stream.el9.
All builds following this will include this PR.

@jinyunma
Copy link
Contributor Author

jinyunma commented Jun 6, 2025

/cherry-pick release-4.19

@openshift-cherrypick-robot

@jinyunma: new pull request created: #9771

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants