Skip to content

CORS-3883: Remove user-assigned identity from ARM template #9625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

jinyunma
Copy link
Contributor

@jinyunma jinyunma commented Apr 1, 2025

For UPI, user-assigned identity attached on each node is also not required, remove it.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2025

@jinyunma: This pull request references CORS-3883 which is a valid jira issue.

In response to this:

For UPI, user-assigned identity attached on each node is also not required, remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2025
@openshift-ci openshift-ci bot requested review from rna-afk and sadasu April 1, 2025 08:49
@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0cb08d1 and 2 for PR HEAD 95c10c0 in total

Copy link
Contributor

openshift-ci bot commented Apr 2, 2025

@jinyunma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack 95c10c0 link false /test e2e-azurestack
ci/prow/e2e-azure-ovn-upi 95c10c0 link false /test e2e-azure-ovn-upi
ci/prow/e2e-azurestack-upi 95c10c0 link false /test e2e-azurestack-upi
ci/prow/e2e-azure-ovn-resourcegroup 95c10c0 link false /test e2e-azure-ovn-resourcegroup
ci/prow/azure-ovn-marketplace-images 95c10c0 link false /test azure-ovn-marketplace-images
ci/prow/e2e-azure-ovn-shared-vpc 95c10c0 link false /test e2e-azure-ovn-shared-vpc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1ddcdff into openshift:main Apr 2, 2025
21 of 27 checks passed
@jinyunma jinyunma deleted the azure-remove-identity branch April 2, 2025 04:28
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.19.0-202504020613.p0.g1ddcdff.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.20.0-202504020613.p0.g1ddcdff.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.20.0-202504020613.p0.g1ddcdff.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.19.0-202504020613.p0.g1ddcdff.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants