Skip to content

OCPBUGS-58216: allow to deploy single nodes with UPI #9763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

OCPBUGS-58216: allow to deploy single nodes with UPI #9763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/asset/machines/master.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,10 +985,10 @@ func IsFencingCredentialsFile(filepath string) (bool, error) {
// a platform.
func supportedSingleNodePlatform(bootstrapInPlace bool, platformName string) bool {
switch platformName {
case awstypes.Name, gcptypes.Name, azuretypes.Name, powervstypes.Name:
case awstypes.Name, gcptypes.Name, azuretypes.Name, powervstypes.Name, nonetypes.Name:
// Single node OpenShift installations supported without `bootstrapInPlace`
return true
case nonetypes.Name, externaltypes.Name:
case externaltypes.Name:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't external platform basically none platform?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if that was the case, the current code would be redundant right?
I think external means the oracle integration used with assisted installer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that's one of the use cases (but it could be other external providers like digital ocean, alibaba).

But no idea why I put this non-sense question here, sorry (must be a long friday, please ignore this 😅 ) Do you have any e2e tests in mind to run to check this change?

// Single node OpenShift installations supported with `bootstrapInPlace`
return bootstrapInPlace
default:
Expand Down