OCPBUGS-58216: allow to deploy single nodes with UPI #9763

karmab · 2025-05-30T12:24:41Z

This PR allows back deployment of single node openshift using UPI with platform None and without bootstrap in place, since it has worked fine for ever and is used at least internally

tthvo · 2025-05-30T17:56:56Z

pkg/asset/machines/master.go

 		// Single node OpenShift installations supported without `bootstrapInPlace`
 		return true
-	case nonetypes.Name, externaltypes.Name:
+	case externaltypes.Name:


Isn't external platform basically none platform?

if that was the case, the current code would be redundant right?
I think external means the oracle integration used with assisted installer

Right, that's one of the use cases (but it could be other external providers like digital ocean, alibaba).

But no idea why I put this non-sense question here, sorry (must be a long friday, please ignore this 😅 ) Do you have any e2e tests in mind to run to check this change?

tthvo

/cc @sadasu

karmab · 2025-06-02T16:36:55Z

/retest

tthvo

/lgtm

The original change is from #9048. This has been backported to 4.18. Do you plan to backport this (might need a chain of OCPBUGS jira ticket)?

barbacbd · 2025-06-02T19:55:28Z

/cc @patrickdillon

@patrickdillon or @sadasu can provide a more meaningful approval here.

patrickdillon · 2025-06-16T20:00:52Z

@sadasu can you review this? You are much more familiar with the SNO landscape than I am.

Vaibhav-Nazare · 2025-06-17T06:27:46Z

Hi, thanks for opening this PR.

We're encountering the same issue while deploying a Single Node OpenShift (SNO) cluster on bare metal using the UPI approach. The installer fails with the following error:

level=fatal msg=failed to fetch Bootstrap Ignition Config: failed to fetch dependency of "Bootstrap Ignition Config": failed to generate asset "Master Machines": this install method does not support Single Node installation on platform none

This deployment method—using platform: none with controlPlane.replicas: 1 and no worker nodes—has been working for a long time and is a common setup for SNO on bare metal with UPI.

Here's the relevant install-config.yaml snippet:

apiVersion: v1
baseDomain: ${CLUSTER_BASE_DOMAIN}
fips: ${FIPS_ENABLED}
metadata:
  name: ${CLUSTER_NAME}
controlPlane:
  architecture: ppc64le
  hyperthreading: Enabled
  name: master
  replicas: 1
networking:
  clusterNetwork:
  - cidr: ${CLUSTER_NETWORK}/14
    hostPrefix: 23
  machineNetwork:  
  - cidr: ${MACHINE_NETWORK}/24
  networkType: ${CLUSTER_NETWORK_TYPE}
  serviceNetwork:
  - 172.30.0.0/16
compute:
- architecture: ${ARCH}
  hyperthreading: Enabled
  name: worker
  replicas: 0
platform:
  none: {}
pullSecret: ${PULL_SECRET}
sshKey: ${SSH_PUB_KEY}

It seems the recent change is unintentionally breaking support for this long-standing approach. We'd really appreciate this fix being merged—happy to help validate or provide additional details if needed.

ccardenosa · 2025-06-26T08:21:26Z

Hello. We are now having this same issue in our Pipelines once we have moved from 4.20.0-ec.2 to 4.20.0-ec.3

Using installer version 4.20.0-ec.3
Using image rhcos-9.6.20250523-0-openstack.x86_64.qcow2
FATAL failed to fetch Master Machines: failed to generate asset "Master Machines": this install method does not support Single Node installation on platform none

We'd really appreciate/need this fix being merged soon.

This is a workaround until the openshift/installer#9763 PR is merged. Then, revert this change. Signed-off-by: Carlos Cardenosa <[email protected]>

This is a workaround until the openshift/installer#9763 PR is merged. [Forgot to remove PR condition in the previous commit] Then, revert this change. Signed-off-by: Carlos Cardenosa <[email protected]>

tthvo · 2025-06-27T22:23:16Z

/retitle OCPBUGS-58216: allow to deploy single nodes with UPI

openshift-ci-robot · 2025-06-27T22:23:27Z

@karmab: This pull request references Jira Issue OCPBUGS-58216, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.0) matches configured target version for branch (4.20.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR allows back deployment of single node openshift using UPI with platform None and without bootstrap in place, since it has worked fine for ever and is used at least internally

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2025-06-30T16:04:51Z

@karmab and @Vaibhav-Nazare, it was my understanding that platform: none was always being used with bootstrapInplace.

@cybertron @mkowalski making sure this is fine w.r.t on-prem networking.

/approve

openshift-ci · 2025-06-30T16:05:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sadasu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mkowalski · 2025-06-30T16:11:18Z

UPI, platform none -- would be very inappropriate for on-prem net team to have anything to block here :)

sadasu · 2025-06-30T16:16:15Z

UPI, platform none -- would be very inappropriate for on-prem net team to have anything to block here :)

Thanks @mkowalski . Noted.

openshift-ci-robot · 2025-06-30T18:11:57Z

/retest-required

Remaining retests: 0 against base HEAD e6e1537 and 2 for PR HEAD 34c9fdd in total

sadasu · 2025-06-30T18:47:54Z

/cherry-pick release-4.19

openshift-cherrypick-robot · 2025-06-30T18:47:57Z

@sadasu: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-06-30T19:11:47Z

@karmab: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`34c9fdd`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-vsphere-ovn-multi-network	`34c9fdd`	link	false	`/test e2e-vsphere-ovn-multi-network`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-06-30T20:20:45Z

/retest-required

Remaining retests: 0 against base HEAD e6e1537 and 2 for PR HEAD 34c9fdd in total

openshift-ci-robot · 2025-07-01T03:10:12Z

@karmab: Jira Issue OCPBUGS-58216: All pull requests linked via external trackers have merged:

openshift/installer#9763

Jira Issue OCPBUGS-58216 has been moved to the MODIFIED state.

In response to this:

This PR allows back deployment of single node openshift using UPI with platform None and without bootstrap in place, since it has worked fine for ever and is used at least internally

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-07-01T03:12:22Z

@sadasu: new pull request created: #9812

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Allow to deploy single nodes with UPI

34c9fdd

openshift-ci bot requested review from barbacbd and tthvo May 30, 2025 12:25

tthvo reviewed May 30, 2025

View reviewed changes

openshift-ci bot requested a review from sadasu May 30, 2025 17:57

tthvo reviewed Jun 2, 2025

View reviewed changes

openshift-ci bot assigned tthvo Jun 2, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2025

openshift-ci bot requested a review from patrickdillon June 2, 2025 19:55

ccardenosa added a commit to ccardenosa/release that referenced this pull request Jun 26, 2025

Fix the OCP version used by Hub deployment

3863324

This is a workaround until the openshift/installer#9763 PR is merged. Then, revert this change. Signed-off-by: Carlos Cardenosa <[email protected]>

ccardenosa mentioned this pull request Jun 26, 2025

Fix the OCP version used by Hub deployment openshift/release#66476

Merged

openshift-ci bot changed the title ~~Allow to deploy single nodes with UPI~~ OCPBUGS-58216: allow to deploy single nodes with UPI Jun 27, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 27, 2025

openshift-ci bot requested a review from gpei June 27, 2025 22:23

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025

openshift-merge-bot bot merged commit 2936edc into openshift:main Jul 1, 2025
16 of 18 checks passed

openshift-cherrypick-robot mentioned this pull request Jul 1, 2025

[release-4.19] OCPBUGS-58263: allow to deploy single nodes with UPI #9812

Merged

OCPBUGS-58216: allow to deploy single nodes with UPI #9763

OCPBUGS-58216: allow to deploy single nodes with UPI #9763

Uh oh!

Conversation

karmab commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tthvo May 30, 2025

Choose a reason for hiding this comment

Uh oh!

karmab May 31, 2025

Choose a reason for hiding this comment

Uh oh!

tthvo Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

tthvo left a comment

Choose a reason for hiding this comment

Uh oh!

karmab commented Jun 2, 2025

Uh oh!

tthvo left a comment

Choose a reason for hiding this comment

Uh oh!

barbacbd commented Jun 2, 2025

Uh oh!

patrickdillon commented Jun 16, 2025

Uh oh!

Vaibhav-Nazare commented Jun 17, 2025

Uh oh!

ccardenosa commented Jun 26, 2025

Uh oh!

tthvo commented Jun 27, 2025

Uh oh!

openshift-ci-robot commented Jun 27, 2025

Uh oh!

sadasu commented Jun 30, 2025

Uh oh!

openshift-ci bot commented Jun 30, 2025

Uh oh!

mkowalski commented Jun 30, 2025

Uh oh!

sadasu commented Jun 30, 2025

Uh oh!

openshift-ci-robot commented Jun 30, 2025

Uh oh!

sadasu commented Jun 30, 2025

Uh oh!

openshift-cherrypick-robot commented Jun 30, 2025

Uh oh!

openshift-ci bot commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 30, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 1, 2025

Uh oh!

openshift-cherrypick-robot commented Jul 1, 2025

Uh oh!

Uh oh!

karmab commented May 30, 2025 •

edited

Loading

openshift-ci bot commented Jun 30, 2025 •

edited

Loading