Skip to content

[release-4.18] OCPBUGS-55794: IBI nmstate unit test fix #9692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

[release-4.18] OCPBUGS-55794: IBI nmstate unit test fix #9692

merged 1 commit into from
May 7, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9680

/assign bfournie

@bfournie
IBI nmstate unit test fix
db0c2a7 
It appears that nmstatectl version 2.44 has additional error output
which causes the unit test string compare to fail. Use a string
subset to ensure the error is captured.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 6, 2025
Merged
@openshift-ci openshift-ci bot requested review from javipolo and mresvanis May 6, 2025 20:28
@bfournie
Copy link
Contributor

bfournie commented May 6, 2025

/retitle [release-4.18] OCPBUGS-55794: IBI nmstate unit test fix

@openshift-ci openshift-ci bot changed the title [release-4.18] no-jira: IBI nmstate unit test fix [release-4.18] OCPBUGS-55794: IBI nmstate unit test fix May 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 6, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-55794, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-55794 to depend on a bug targeting a version in 4.19.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #9680

/assign bfournie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie
Copy link
Contributor

bfournie commented May 6, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-55794, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie
Copy link
Contributor

bfournie commented May 6, 2025 •
edited
Loading

/jira refresh

1 similar comment
@bfournie
Copy link
Contributor

bfournie commented May 6, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@bfournie: An error was encountered updating to the POST state for bug OCPBUGS-55794 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. No response returned: Post "https://issues.redhat.com/rest/api/2/issue/16880875/transitions": POST https://issues.redhat.com/rest/api/2/issue/16880875/transitions giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie
Copy link
Contributor

bfournie commented May 6, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 6, 2025
@openshift-ci-robot
Copy link
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-55794, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-55796 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-55796 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gpei May 6, 2025 20:41
@bfournie
Copy link
Contributor

bfournie commented May 6, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 6, 2025
tthvo
tthvo reviewed May 6, 2025
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I can't approve in 4.18 😅

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2025
@patrickdillon
Copy link
Contributor

/label backport-risk-assessed
/override ci/prow/tf-lint ci/prow/tf-fmt ci/prow/yaml-lint ci/prow/shellcheck

I think they are actually making progress on fixing these tests.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 6, 2025

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/shellcheck, ci/prow/tf-fmt, ci/prow/tf-lint, ci/prow/yaml-lint

In response to this:

/label backport-risk-assessed
/override ci/prow/tf-lint ci/prow/tf-fmt ci/prow/yaml-lint ci/prow/shellcheck

I think they are actually making progress on fixing these tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@patrickdillon
Copy link
Contributor

Bob can self-approve but I'll take care of it anyway
/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@bmanzari
Copy link

bmanzari commented May 7, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 7, 2025
@bfournie
Copy link
Contributor

bfournie commented May 7, 2025

/retest-required

@bfournie
Copy link
Contributor

bfournie commented May 7, 2025

/override ci/prow/tf-lint ci/prow/tf-fmt ci/prow/yaml-lint ci/prow/shellcheck

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2025

@bfournie: Overrode contexts on behalf of bfournie: ci/prow/shellcheck, ci/prow/tf-fmt, ci/prow/tf-lint, ci/prow/yaml-lint

In response to this:

/override ci/prow/tf-lint ci/prow/tf-fmt ci/prow/yaml-lint ci/prow/shellcheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bfournie
Copy link
Contributor

bfournie commented May 7, 2025

/override ci/prow/tf-lint ci/prow/tf-fmt ci/prow/yaml-lint ci/prow/shellcheck

1 similar comment
@bfournie
Copy link
Contributor

bfournie commented May 7, 2025

/override ci/prow/tf-lint ci/prow/tf-fmt ci/prow/yaml-lint ci/prow/shellcheck

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2025

@bfournie: Overrode contexts on behalf of bfournie: ci/prow/shellcheck, ci/prow/tf-fmt, ci/prow/tf-lint, ci/prow/yaml-lint

In response to this:

/override ci/prow/tf-lint ci/prow/tf-fmt ci/prow/yaml-lint ci/prow/shellcheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn db0c2a7 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-images db0c2a7 link false /test okd-scos-images
ci/prow/e2e-azure-ovn-resourcegroup db0c2a7 link false /test e2e-azure-ovn-resourcegroup

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit aade717 into openshift:release-4.18 May 7, 2025
19 of 22 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-55794: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55794 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #9680

/assign bfournie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie bfournie mentioned this pull request May 7, 2025
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.18.0-202505071937.p0.gaade717.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.18.0-202505071937.p0.gaade717.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.18.0-202505071937.p0.gaade717.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.18.0-202505071937.p0.gaade717.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.18.0-0.nightly-2025-05-08-091322

@tthvo tthvo mentioned this pull request May 21, 2025
Merged
@bfournie
Copy link
Contributor

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link
Author

@bfournie: new pull request created: #9777

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo left review comments

@javipolo javipolo Awaiting requested review from javipolo

@mresvanis mresvanis Awaiting requested review from mresvanis

@gpei gpei Awaiting requested review from gpei

Assignees

@bfournie bfournie

@tthvo tthvo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@openshift-cherrypick-robot @bfournie @openshift-ci-robot @patrickdillon @bmanzari @openshift-bot @openshift-merge-robot @tthvo