no-jira: IBI nmstate unit test fix #9680
Conversation
It appears that nmstatectl version 2.44 has additional error output which causes the unit test string compare to fail. Use a string subset to ensure the error is captured.
bfournie
force-pushed
the
ibi-unit-test-fix
branch
from
8842a04 to
f01be21
Compare
|
@bfournie: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve This seems non-controversial and let's get it in quickly... /retitle no-jira: IBI nmstate unit test fix |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@bfournie: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Not that I can read Rust 😆 but I traced it back to this commit, where they refactored the handler code for parsing network state. This changed the error message. The original use of function new_from_yaml (i.e. removed) returns the original error message. So, I think checking the final part of the error here makes sense 😄 |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/skip |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
|
/cherry-pick release-4.18 |
|
@bfournie: new pull request created: #9692 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jcpowermac I didn't realize this was also needed in 4.18, but yes, did the backport. |
It appears that nmstatectl version 2.44 has additional error output which causes the unit test string compare to fail. Use a string subset to ensure the error is captured.