cmd/openshift-install: Remove deprecated commands

[wking]

These have been deprecated since 3f4fe57 (#493) and 85c76c9 (#513). The destroy commands were deprecated before the 0.3.0 release, so removing them now should be fine. The create commands landed after 0.3.0, but it's been a long time since they were deprecated. Our released versions currently go stale pretty fast, so there are unlikely to be any consumers of the old create commands that this removal would break.

/assign @crawford

[abhinavdahiya]

/approve

[abhinavdahiya]

/lgtm

[abhinavdahiya]

/retest

[wking]

e2e-aws:

2018/11/21 21:25:26 Container artifacts in pod release-latest completed successfully
E1121 23:24:04.762664      11 event.go:200] Server rejected event '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:".1569473605f22089", GenerateName:"", Namespace:"ci-op-cvqt5p6q", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, InvolvedObject:v1.ObjectReference{Kind:"", Namespace:"ci-op-cvqt5p6q", Name:"", UID:"", APIVersion:"", ResourceVersion:"", FieldPath:""}, Reason:"CiJobFailed", Message:"Running job pull-ci-openshift-installer-master-e2e-aws for PR https://github.com/openshift/installer/pull/715 in namespace ci-op-cvqt5p6q from author wking", Source:v1.EventSource{Component:"ci-op-cvqt5p6q", Host:""}, FirstTimestamp:v1.Time{Time:time.Time{wall:0xbef598252a005889, ext:7345399440371, loc:(*time.Location)(0x1975400)}}, LastTimestamp:v1.Time{Time:time.Time{wall:0xbef598252a005889, ext:7345399440371, loc:(*time.Location)(0x1975400)}}, Count:1, Type:"Warning", EventTime:v1.MicroTime{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, Series:(*v1.EventSeries)(nil), Action:"", Related:(*v1.ObjectReference)(nil), ReportingController:"", ReportingInstance:""}': 'namespaces "ci-op-cvqt5p6q" not found' (will not retry!)
2018/11/21 23:24:05 Ran for 2h2m26s
error: could not run steps: failed to wait for release pod to complete: could not wait for pod completion: could not list pod: pods "release-latest" is forbidden: User "system:serviceaccount:ci:ci-operator" cannot list pods in the namespace "ci-op-cvqt5p6q": no RBAC policy matched

/retest

[wking]

e2e-aws:

evel=info msg="Using Terraform to create cluster..."
level=debug msg="Running &exec.Cmd{Path:\"/usr/bin/terraform\", Args:[]string{\"/usr/bin/terraform\", \"init\", \"-input=false\", \"-no-color\"}, Env:[]string(nil), Dir:\"/tmp/openshift-install-557383515\", Stdin:io.Reader(nil), Stdout:io.Writer(nil), Stderr:io.Writer(nil), ExtraFiles:[]*os.File(nil), SysProcAttr:(*syscall.SysProcAttr)(nil), Process:(*os.Process)(nil), ProcessState:(*os.ProcessState)(nil), ctx:context.Context(nil), lookPathErr:error(nil), finished:false, childFiles:[]*os.File(nil), closeAfterStart:[]io.Closer(nil), closeAfterWait:[]io.Closer(nil), goroutine:[]func() error(nil), errch:(chan error)(nil), waitDone:(chan struct {})(nil)}..."
level=debug msg="Running &exec.Cmd{Path:\"/usr/bin/terraform\", Args:[]string{\"/usr/bin/terraform\", \"apply\", \"-auto-approve\", \"-input=false\", \"-no-color\", \"-state=terraform.tfstate\"}, Env:[]string(nil), Dir:\"/tmp/openshift-install-557383515\", Stdin:io.Reader(nil), Stdout:io.Writer(nil), Stderr:io.Writer(nil), ExtraFiles:[]*os.File(nil), SysProcAttr:(*syscall.SysProcAttr)(nil), Process:(*os.Process)(nil), ProcessState:(*os.ProcessState)(nil), ctx:context.Context(nil), lookPathErr:error(nil), finished:false, childFiles:[]*os.File(nil), closeAfterStart:[]io.Closer(nil), closeAfterWait:[]io.Closer(nil), goroutine:[]func() error(nil), errch:(chan error)(nil), waitDone:(chan struct {})(nil)}..."
level=error msg="Error: Error applying plan:\n\n1 error(s) occurred:\n\n* aws_route53_zone.tectonic_int: 1 error(s) occurred:\n\n* aws_route53_zone.tectonic_int: timeout while waiting for state to become 'INSYNC' (last state: 'PENDING', timeout: 15m0s)\n\nTerraform does not automatically rollback in the face of errors.\nInstead, your Terraform state file has been partially updated with\nany resources that successfully completed. Please address the error\nabove and apply again to incrementally change your infrastructure."
level=fatal msg="Error executing openshift-install: failed to fetch Cluster: failed to generate asset \"Cluster\": failed to run terraform: failed to execute Terraform: exit status 1"
2018/11/21 23:50:06 Container setup in pod e2e-aws failed, exit code 1, reason Error

/retest

[abhinavdahiya]

same same error here openshift/machine-config-operator#191 (comment) :/

[sallyom]

@wking, the e2e-libvirt job should not run by default! Did you comment to run it? In the release repo presubmits I have:
always_run: false
optional: true

[wking]

the e2e-libvirt job should not run by default...

I didn't do anything to turn it on, but since it's optional, I don't think it matters if it runs.

e2e-aws looks like it's still stuck on job 715, so kicking it directly:

/test e2e-aws

Edit: I'm getting sleepy, 715 is the PR number. The last e2e-aws error was job 1540, although it had the same failure mode:

level=error msg="Error: Error applying plan:\n\n1 error(s) occurred:\n\n* aws_route53_zone.tectonic_int: 1 error(s) occurred:\n\n* aws_route53_zone.tectonic_int: timeout while waiting for state to become 'INSYNC' (last state: 'PENDING', timeout: 15m0s)\n\nTerraform does not automatically rollback in the face of errors.\nInstead, your Terraform state file has been partially updated with\nany resources that successfully completed. Please address the error\nabove and apply again to incrementally change your infrastructure."

[crawford]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya,crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[crawford]

/retest

[wking]

e2e-aws included:

fail [github.com/openshift/origin/test/extended/router/router.go:58]: Expected error:
    <*errors.errorString | 0xc4200cf560>: {
        s: "timed out waiting for the condition",
    }
    timed out waiting for the condition
not to have occurred

failed: (4m54s) "[Conformance][Area:Networking][Feature:Router] The HAProxy router should serve routes that were created from an ingress [Suite:openshift/conformance/parallel/minimal] [Suite:openshift/smoke-4]"

/test e2e-aws

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@wking: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-libvirt	e63f0e6	link	/test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.