cmd/openshift-install: Push creation under 'openshift create' #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
|
deprecate all the of old ones :P |
To mirror 'openshift-install destroy' and make it easier for folks using multiple invocations to see what their options are. I've deprecated all the old commands, and am looking forward to dropping them as soon as possible :).
wking
force-pushed
the
create-sub-commands
branch
from
54f983b to
85c76c9
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Oct 26, 2018
…uster' Catching up with openshift/installer@3f4fe574 (cmd/openshift-install: Add 'destroy bootstrap' command, openshift/installer#493). Also change 'cluster' -> 'create cluster' to catch up with openshift/installer@85c76c98 (cmd/openshift-install: Push creation under 'openshift create', 2018-10-22, openshift/installer#513).
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Nov 21, 2018
These have been deprecated since 3f4fe57 (cmd/openshift-install: Add 'destroy bootstrap' command, 2018-10-18, openshift#493) and 85c76c9 (cmd/openshift-install: Push creation under 'openshift create', 2018-10-22, openshift#513). The destroy commands were deprecated before the 0.3.0 release, so removing them now should be fine. The create commands landed after 0.3.0, but it's been a long time since they were deprecated. Our released versions currently go stale pretty fast, so there are unlikely to be any consumers of the old create commands that this removal would break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mirror
openshift-install destroyand make it easier for folks using multiple invocations to see what their options are.I haven't bothered with deprecated backwards-compat invocations, because I didn't know which targets we'd want it for (all of them? None of them? Just
cluster?). Thoughts?