-
Notifications
You must be signed in to change notification settings - Fork 1.4k
use official red hat tooling image #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/lgtm |
hack/go-fmt.sh
Outdated
@@ -9,7 +9,6 @@ else | |||
--env IS_CONTAINER=TRUE \ | |||
--volume "${PWD}:/go/src/github.com/openshift/installer:z" \ | |||
--workdir /go/src/github.com/openshift/installer \ | |||
--entrypoint sh \ | |||
quay.io/coreos/golang-testing \ | |||
openshift/origin-release:golang-1.10 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some strange reason this image isn't present on quay (CC: @smarterclayton @stevekuznetsov).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a released image for use by customers, so we do not mirror it to quay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a released image for use by customers, so we do not mirror it to quay.
So should we have a docker.io/
prefix here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
/lgtm Can you file a PR for this and similar too? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, spangenberg, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Of course, here it is: openshift/release#1443 |
No one should be assuming images are on quay yet. Docker is still
canonical source for tooling images. We will possibly move them later this
month but there are other short term priorities in the way.
On Sep 10, 2018, at 1:02 PM, Paweł Krupa <[email protected]> wrote:
*@paulfantom* commented on this pull request.
------------------------------
In hack/go-fmt.sh
<#227 (comment)>:
@@ -9,7 +9,6 @@ else
--env IS_CONTAINER=TRUE \
--volume "${PWD}:/go/src/github.com/openshift/installer:z" \
--workdir /go/src/github.com/openshift/installer \
- --entrypoint sh \
- quay.io/coreos/golang-testing \
+ openshift/origin-release:golang-1.10 \
For some strange reason this image isn't present on quay (CC:
@smarterclayton <https://github.com/smarterclayton> @stevekuznetsov
<https://github.com/stevekuznetsov>).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#227 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AG7fCthKIHvisffoo8aDD7OATQLm0ztzks5uZpsYgaJpZM4Whcao>
.
|
Who is @openshift-docker ? |
Me. |
Use Red Hat tooling image instead of my coreos one 😄
Same as openshift/cluster-api-provider-aws#40
/CC: @wking