Skip to content

use official red hat tooling image #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2018

Conversation

paulfantom
Copy link
Contributor

Use Red Hat tooling image instead of my coreos one 😄

Same as openshift/cluster-api-provider-aws#40

/CC: @wking

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2018
@spangenberg
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2018
@wking wking mentioned this pull request Sep 10, 2018
hack/go-fmt.sh Outdated
@@ -9,7 +9,6 @@ else
--env IS_CONTAINER=TRUE \
--volume "${PWD}:/go/src/github.com/openshift/installer:z" \
--workdir /go/src/github.com/openshift/installer \
--entrypoint sh \
quay.io/coreos/golang-testing \
openshift/origin-release:golang-1.10 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the registry prefix? What if a user is using something based on containers/image (e.g. podman) to pull these and they happen to have neither quay.io nor docker.io in their default search config (docs here and here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some strange reason this image isn't present on quay (CC: @smarterclayton @stevekuznetsov).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a released image for use by customers, so we do not mirror it to quay.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a released image for use by customers, so we do not mirror it to quay.

So should we have a docker.io/ prefix here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@wking
Copy link
Member

wking commented Sep 10, 2018

Can we also update this and this (CC @sallyom)?

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2018
@wking
Copy link
Member

wking commented Sep 11, 2018

/lgtm

Can you file a PR for this and similar too?

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, spangenberg, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2018
@paulfantom
Copy link
Contributor Author

Of course, here it is: openshift/release#1443
I didn't use docker.io prefix there as prow cluster should already have this image in internal registry.

@openshift-docker
Copy link

openshift-docker commented Sep 16, 2018 via email

@paulfantom
Copy link
Contributor Author

Who is @openshift-docker ?

@smarterclayton
Copy link
Contributor

Me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants