use origin-release images for tooling #40
Conversation
openshift-ci-robot
added
size/XS
openshift-ci-robot
added
size/S
|
@paulfantom: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -56,7 +56,7 @@ integration: | |||
| go test -v sigs.k8s.io/cluster-api-provider-aws/test/integration | |||
|
|
|||
| fmt: | |||
| hack/verify-gofmt.sh | |||
| hack/go-fmt.sh . | |||
There was a problem hiding this comment.
Is go-fmt different to go-vet w.r.t. passing ./.... One does, the other doesn't. Curious as to why.
There was a problem hiding this comment.
No idea, that's how installer runs it.
All those scripts are created by guys from installer team, we just copy-pasted them.
There was a problem hiding this comment.
You just need to look at the code of the script https://github.com/openshift/cluster-api-provider-aws/blob/master/hack/go-fmt.sh#L4 https://golang.org/cmd/gofmt/
| @@ -9,7 +9,6 @@ else | |||
| --env IS_CONTAINER=TRUE \ | |||
| --volume "${PWD}:/go/src/sigs.k8s.io/cluster-api-provider-aws:z" \ | |||
| --workdir /go/src/sigs.k8s.io/cluster-api-provider-aws \ | |||
| --entrypoint sh \ | |||
| quay.io/coreos/golang-testing \ | |||
| openshift/origin-release:golang-1.10 \ | |||
| ./hack/go-fmt.sh "${@}" | |||
There was a problem hiding this comment.
ShellCheck says that both are valid.
|
/lgmt |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, paulfantom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Use redhat tooling image