hack/build: Pin to RHCOS 47.249 and quay.io/openshift-release-dev/ocp-release:4.0.0-0.1 (v0.10.1) #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Through b166e2e (Merge pull request openshift#1039 from wking/tag-search-destroy, 2019-01-22).
…-release:4.0.0-0.1 Recycling the RHCOS build from 76f91bd (hack/build: Bump RHCOS from 47.245 to 47.249, 2019-01-07, openshift#1009, v0.9.1). Clayton pushed 4.0-art-latest-2019-01-15-010905 to quay.io/openshift-release-dev/ocp-release:4.0.0-0.1 for 0.10.0, and we've had stability issues in master since then, so we're cutting this release without an update-payload bump. Renaming OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE gets us CI testing of the pinned release despite openshift/release@60007df2 (Use RELEASE_IMAGE_LATEST for CVO payload, 2018-10-03, openshift/release#1793). Also comment out regions which this particular RHCOS build wasn't pushed to, leaving only: $ curl -s https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/47.246/meta.json | jq -r '.amis[] | .name' ap-northeast-1 ap-northeast-2 ap-south-1 ap-southeast-1 ap-southeast-2 ca-central-1 eu-central-1 eu-west-1 eu-west-2 eu-west-3 sa-east-1 us-east-1 us-east-2 us-west-1 us-west-2 I'd initially expected to export the pinning environment variables in release.sh, but I've put them in build.sh here because our continuous integration tests use build.sh directly and don't go through release.sh.
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
|
e2e-aws hung: /retest |
|
All green, and tagged as v0.10.1. |
sttts
reviewed
Jan 24, 2019
| @@ -145,7 +145,7 @@ func (a *Bootstrap) getTemplateData(installConfig *types.InstallConfig) (*bootst | |||
| } | |||
|
|
|||
| releaseImage := defaultReleaseImage | |||
| if ri, ok := os.LookupEnv("OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE"); ok && ri != "" { | |||
| if ri, ok := os.LookupEnv("_OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE"); ok && ri != "" { | |||
There was a problem hiding this comment.
So that the CI doesn't override our image with the latest. It's a hack, but we don't support overriding the release image, so nobody should need this.
There was a problem hiding this comment.
Notes on this in the commit message too, but since we've used this pattern a few times now I didn't copy that paragraph into the PR post.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE! This PR is just for CI coverage.
Recycling the RHCOS build from 76f91bd (#1009, v0.9.1).
Recycling the update payload from 9ccba22 (#1068, v0.10.0). We've had stability issues in master since then which are blocking a new update-payload.