Skip to content

hack/build: Bump RHCOS from 47.245 to 47.249 #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wking
Copy link
Member

@wking wking commented Jan 7, 2019

To fix a bug where Ignition was run on every boot (when it should only run on the first boot).

The 47.249 build is still running, but I thought I'd push this up so it's ready when the build goes out.

CC @crawford

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 7, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2019
To fix a bug where Ignition was run on every boot (when it should only
run on the first boot).
@wking wking force-pushed the version-0.9.1-pins branch from 277534f to 76f91bd Compare January 7, 2019 17:58
@ashcrow
Copy link
Member

ashcrow commented Jan 7, 2019

Thank you @wking

@wking
Copy link
Member Author

wking commented Jan 7, 2019

Build is up.

/retest

@crawford
Copy link
Contributor

crawford commented Jan 7, 2019

This looks good. We aren't planning on merging this, correct? It will just end up under a tag?

@crawford
Copy link
Contributor

crawford commented Jan 7, 2019

failed to fetch Terraform Variables: failed to fetch dependency of "Terraform Variables": failed to fetch dependency of "Bootstrap Ignition Config": failed to fetch dependency of "Openshift Manifests": failed to generate asset "Worker Machines": failed to determine default AMI: failed to fetch RHCOS metadata: incorrect HTTP response (404 Not Found)

Looks like the upload succeeded.

/retest

@wking
Copy link
Member Author

wking commented Jan 7, 2019

We aren't planning on merging this, correct? It will just end up under a tag?

Yeah, I don't think we need to bother merging, I'll just tag this once we have green CI.

@wking
Copy link
Member Author

wking commented Jan 7, 2019

e2e-aws:

Flaky tests:

[Feature:DeploymentConfig] deploymentconfigs when run iteratively [Conformance] should immediately start a new deployment [Suite:openshift/conformance/parallel/minimal]
[Feature:DeploymentConfig] deploymentconfigs with test deployments [Conformance] should run a deployment to completion and then scale to zero [Suite:openshift/conformance/parallel/minimal]
[sig-storage] Dynamic Provisioning DynamicProvisioner should test that deleting a claim before the volume is provisioned deletes the volume. [Suite:openshift/conformance/parallel] [Suite:k8s] [Suite:openshift/smoke-4]

Writing JUnit report to /tmp/artifacts/junit/junit_e2e_20190107-193118.xml

Error: 3 fail, 521 pass, 97 skip (28m42s)
2019/01/07 19:31:18 Container test in pod e2e-aws failed, exit code 1, reason Error

Checking the promotion test-grid, the first two are known flakes. But the sig-storage error hasn't happened in promotion CI. Is that a real issue with this update-payload/RHCOS combination?

@wking
Copy link
Member Author

wking commented Jan 7, 2019

More details on the sig-storage failure:

Jan  7 19:25:37.497: INFO: Running AfterSuite actions on node 1
fail [k8s.io/kubernetes/test/e2e/storage/volume_provisioning.go:585]: Expected error:
    <*errors.errorString | 0xc420095560>: {
        s: "timed out waiting for the condition",
    }
    timed out waiting for the condition
not to have occurred

Jan 07 19:20:18.229 W persistentvolume=pvc-4412cf43-12b1-11e9-aa77-0e19e50dd334 Error deleting EBS volume "vol-0212e228e7ba6ebc2" since volume is in "creating" state
...
Jan 07 19:20:24.626 W persistentvolume=pvc-47b5511a-12b1-11e9-aa77-0e19e50dd334 Error deleting EBS volume "vol-0b3abd615fd4c8333" since volume is in "creating" state
Jan 07 19:21:30.431 W persistentvolume=pvc-44c3aaec-12b1-11e9-9518-0a83a7960b64 Error deleting EBS volume "vol-0354240e5b3da2362" since volume is currently attached to "i-0f82edec1140e60b7"
Jan 07 19:22:39.479 I ns=openshift-kube-apiserver-operator deployment=openshift-kube-apiserver-operator Allowed registries for import changed to []
Jan 07 19:22:54.361 W persistentvolume=pvc-48c56170-12b1-11e9-9518-0a83a7960b64 Error deleting EBS volume "vol-0c9b1b840d14daa34" since volume is currently attached to "i-0f82edec1140e60b7"

failed: (5m24s) 2019-01-07T19:25:37 "[sig-storage] Dynamic Provisioning DynamicProvisioner should test that deleting a claim before the volume is provisioned deletes the volume. [Suite:openshift/conformance/parallel] [Suite:k8s] [Suite:openshift/smoke-4]"

That smells like a flake to me, so I'll go ahead and push the release now. In case it gets us pretty, green CI, I'll give it one more shot in the meantime ;)

/retest

@ashcrow
Copy link
Member

ashcrow commented Jan 7, 2019

I've been seeing a lot of failures today as well. Likely a flake.

@openshift-ci-robot
Copy link
Contributor

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 76f91bd link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member Author

wking commented Jan 7, 2019

This time around:

Flaky tests:

[Feature:DeploymentConfig] deploymentconfigs with custom deployments [Conformance] should run the custom deployment steps [Suite:openshift/conformance/parallel/minimal]
[sig-auth] ServiceAccounts should allow opting out of API token automount  [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]

Writing JUnit report to /tmp/artifacts/junit/junit_e2e_20190107-204134.xml

Error: 2 fail, 522 pass, 97 skip (30m59s)

So between the two runs, all of the tests passed ;). And 0.9.1 is out with this content.

@wking wking closed this Jan 7, 2019
@wking wking deleted the version-0.9.1-pins branch January 7, 2019 20:49
wking added a commit to wking/openshift-installer that referenced this pull request Jan 15, 2019
…-release:4.0.0-0.1

Recycling the RHCOS build from 76f91bd (hack/build: Bump RHCOS from
47.245 to 47.249, 2019-01-07, openshift#1009, v0.9.1).

Clayton just pushed 4.0-art-latest-2019-01-15-010905 to
quay.io/openshift-release-dev/ocp-release:4.0.0-0.1, although we might
update that tag with a later hot fix.  We're cutting this release on
4.0.0-0.1 so folks can use a (mostly) pinned installer with an
(almost) released update payload ;).

Renaming OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE gets us CI testing
of the pinned release despite openshift/release@60007df2 (Use
RELEASE_IMAGE_LATEST for CVO payload, 2018-10-03,
openshift/release#1793).

Also comment out regions which this particular RHCOS build wasn't
pushed to, leaving only:

  $ curl -s https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/47.246/meta.json | jq -r '.amis[] | .name'
  ap-northeast-1
  ap-northeast-2
  ap-south-1
  ap-southeast-1
  ap-southeast-2
  ca-central-1
  eu-central-1
  eu-west-1
  eu-west-2
  eu-west-3
  sa-east-1
  us-east-1
  us-east-2
  us-west-1
  us-west-2

I'd initially expected to export the pinning environment variables in
release.sh, but I've put them in build.sh here because our continuous
integration tests use build.sh directly and don't go through
release.sh.
wking added a commit to wking/openshift-installer that referenced this pull request Jan 22, 2019
…-release:4.0.0-0.1

Recycling the RHCOS build from 76f91bd (hack/build: Bump RHCOS from
47.245 to 47.249, 2019-01-07, openshift#1009, v0.9.1).

Clayton pushed 4.0-art-latest-2019-01-15-010905 to
quay.io/openshift-release-dev/ocp-release:4.0.0-0.1 for 0.10.0, and
we've had stability issues in master since then, so we're cutting this
release without an update-payload bump.

Renaming OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE gets us CI testing
of the pinned release despite openshift/release@60007df2 (Use
RELEASE_IMAGE_LATEST for CVO payload, 2018-10-03,
openshift/release#1793).

Also comment out regions which this particular RHCOS build wasn't
pushed to, leaving only:

  $ curl -s https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/47.246/meta.json | jq -r '.amis[] | .name'
  ap-northeast-1
  ap-northeast-2
  ap-south-1
  ap-southeast-1
  ap-southeast-2
  ca-central-1
  eu-central-1
  eu-west-1
  eu-west-2
  eu-west-3
  sa-east-1
  us-east-1
  us-east-2
  us-west-1
  us-west-2

I'd initially expected to export the pinning environment variables in
release.sh, but I've put them in build.sh here because our continuous
integration tests use build.sh directly and don't go through
release.sh.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants