-
Notifications
You must be signed in to change notification settings - Fork 1.4k
hack/build: Bump RHCOS from 47.245 to 47.249 #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To fix a bug where Ignition was run on every boot (when it should only run on the first boot).
277534f
to
76f91bd
Compare
Thank you @wking |
Build is up. /retest |
This looks good. We aren't planning on merging this, correct? It will just end up under a tag? |
Looks like the upload succeeded. /retest |
Yeah, I don't think we need to bother merging, I'll just tag this once we have green CI. |
Checking the promotion test-grid, the first two are known flakes. But the sig-storage error hasn't happened in promotion CI. Is that a real issue with this update-payload/RHCOS combination? |
More details on the sig-storage failure:
That smells like a flake to me, so I'll go ahead and push the release now. In case it gets us pretty, green CI, I'll give it one more shot in the meantime ;) /retest |
I've been seeing a lot of failures today as well. Likely a flake. |
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
So between the two runs, all of the tests passed ;). And 0.9.1 is out with this content. |
…-release:4.0.0-0.1 Recycling the RHCOS build from 76f91bd (hack/build: Bump RHCOS from 47.245 to 47.249, 2019-01-07, openshift#1009, v0.9.1). Clayton just pushed 4.0-art-latest-2019-01-15-010905 to quay.io/openshift-release-dev/ocp-release:4.0.0-0.1, although we might update that tag with a later hot fix. We're cutting this release on 4.0.0-0.1 so folks can use a (mostly) pinned installer with an (almost) released update payload ;). Renaming OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE gets us CI testing of the pinned release despite openshift/release@60007df2 (Use RELEASE_IMAGE_LATEST for CVO payload, 2018-10-03, openshift/release#1793). Also comment out regions which this particular RHCOS build wasn't pushed to, leaving only: $ curl -s https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/47.246/meta.json | jq -r '.amis[] | .name' ap-northeast-1 ap-northeast-2 ap-south-1 ap-southeast-1 ap-southeast-2 ca-central-1 eu-central-1 eu-west-1 eu-west-2 eu-west-3 sa-east-1 us-east-1 us-east-2 us-west-1 us-west-2 I'd initially expected to export the pinning environment variables in release.sh, but I've put them in build.sh here because our continuous integration tests use build.sh directly and don't go through release.sh.
…-release:4.0.0-0.1 Recycling the RHCOS build from 76f91bd (hack/build: Bump RHCOS from 47.245 to 47.249, 2019-01-07, openshift#1009, v0.9.1). Clayton pushed 4.0-art-latest-2019-01-15-010905 to quay.io/openshift-release-dev/ocp-release:4.0.0-0.1 for 0.10.0, and we've had stability issues in master since then, so we're cutting this release without an update-payload bump. Renaming OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE gets us CI testing of the pinned release despite openshift/release@60007df2 (Use RELEASE_IMAGE_LATEST for CVO payload, 2018-10-03, openshift/release#1793). Also comment out regions which this particular RHCOS build wasn't pushed to, leaving only: $ curl -s https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/47.246/meta.json | jq -r '.amis[] | .name' ap-northeast-1 ap-northeast-2 ap-south-1 ap-southeast-1 ap-southeast-2 ca-central-1 eu-central-1 eu-west-1 eu-west-2 eu-west-3 sa-east-1 us-east-1 us-east-2 us-west-1 us-west-2 I'd initially expected to export the pinning environment variables in release.sh, but I've put them in build.sh here because our continuous integration tests use build.sh directly and don't go through release.sh.
To fix a bug where Ignition was run on every boot (when it should only run on the first boot).
The 47.249 build is still running, but I thought I'd push this up so it's ready when the build goes out.
CC @crawford