OCPBUGS-56114: Fix ImplicitlyEnabledCapabilities #1191
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@hongkailiu: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @petr-muller @jiajliu |
|
Good find. Will we need to backport this to 4.19? If so we'll need an OCPBUGS card. |
|
/hold Let me create a card because of the backporting. Checked the dates: and #1157 got in on Feb 25, 2025. So backport only to 4.19. |
openshift-ci
bot
added
the
do-not-merge/hold
hongkailiu
changed the title
openshift-ci-robot
added
jira/severity-important
|
@hongkailiu: This pull request references Jira Issue OCPBUGS-56114, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@hongkailiu: This pull request references Jira Issue OCPBUGS-56114, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Huh we apparently have some test gaps if we can change the value in the API and no tests fail 🤨 |
openshift-ci
bot
added
lgtm
After this pull, the gaps should be closed, e.g., by https://github.com/openshift/cluster-version-operator/pull/1191/files#diff-95a39e68d5f2a7a2f3e7236db558c3154a9967e84f74810888386b13485d5e2fL118 IIRC, I was told (by our Steve 😄 ) that Unit tests should be using direct inputs (instead of constants from the core code). |
This commit addresses the issue found in the last round of pre-merge test [1]. This commit could be reverted after maximal 2 releases. (It is alright to keep it too) Assume this PR gets merged to main which is ATM dev branch: 4.20. When the main branches points to 4.22, all the clusters affetecd by the bug (originally 4.19 and 4.20) should be fixed when they are upgraded to 4.20/4.21. Thus any 4.22 cluster should not be affected. [1]. https://issues.redhat.com/browse/OCPBUGS-56114?focusedId=27251461&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-27251461
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu, petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hongkailiu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
openshift-merge-bot
bot
merged commit b6ad9e5
into
openshift:main
|
@hongkailiu: Jira Issue OCPBUGS-56114: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-56114 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.19 |
|
@jiajliu: new pull request created: #1199 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: cluster-version-operator |
It is a mistake introduced by https://github.com/openshift/cluster-version-operator/pull/1157/files#diff-db97dc5ae62ef3b4c4dabfdc43cbc3ae0ceae9b58748cadebde679e32b5bec2bL175
As a result, it changes the type name in ClusterVersion which was definitely not the intension of #1157. So we change the constant back with this pull.
The mistake is found by @jiajliu while doing the pre-merge testing for #1133.
It looks like I was not careful enough before confirming IDE (GoLand)'s smart editing. My apologies for that.
Additionally, a couple of cases in unit tests are modified in the pull to avoid regression like this from happening again.