Skip to content

NO-JIRA: Rename fields in ClusterCapabilities for readability #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

NO-JIRA: Rename fields in ClusterCapabilities for readability #1157

merged 1 commit into from
Feb 25, 2025

Conversation

hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Feb 14, 2025 •
edited
Loading

Follow up #1131 (review)

Will rebase after #1131 gets in.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 14, 2025
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This pull request explicitly references no jira issue.

In response to this:

Will rebase after #1131 gets in.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2025
@openshift-ci openshift-ci bot requested review from DavidHurta and wking February 14, 2025 15:48
@hongkailiu hongkailiu mentioned this pull request Feb 15, 2025
Merged
@hongkailiu hongkailiu changed the title [wip]NO-JIRA: Rename fields in ClusterCapabilities for readability NO-JIRA: Rename fields in ClusterCapabilities for readability Feb 25, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

@hongkailiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 2c27ff6 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

petr-muller
petr-muller approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label no-qe

No targeted testing necessary, this is just refactoring without any functional changes

@openshift-ci openshift-ci bot added the no-qe Allows PRs to merge without qe-approved label label Feb 25, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2025
@hongkailiu
Copy link
Member Author

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 25115ba into openshift:main Feb 25, 2025
13 of 14 checks passed
@hongkailiu hongkailiu mentioned this pull request May 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-muller petr-muller petr-muller approved these changes

@DavidHurta DavidHurta Awaiting requested review from DavidHurta

@wking wking Awaiting requested review from wking

Assignees

@petr-muller petr-muller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. no-qe Allows PRs to merge without qe-approved label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongkailiu @openshift-ci-robot @petr-muller