[release-4.17] OCPBUGS-58248: ccoctl: only add owned tag to azure resources on create #883

openshift-cherrypick-robot · 2025-06-30T22:24:19Z

This is an automated cherry-pick of #876

/assign openshift-ci-robot

Prior to this change, ccoctl always added the owned tag to the resource groups and storage accounts. This caused errors when the number of owned tags from multpiple clusters exceeded the maximum tag limit. This change makes it so the owned tag is only added when a resource group or storage account is actually created. Any additional clusters using these resources will not attempt to add their own owned tag. This enables significantly more clusters to share the same resources without reaching the limit.

openshift-ci-robot · 2025-06-30T22:24:24Z

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-53454 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.17] OCPBUGS-58248: ccoctl: only add owned tag to azure resources on create

In response to this:

This is an automated cherry-pick of #876

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-06-30T22:24:45Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-58248, which is invalid:

expected dependent Jira Issue OCPBUGS-58247 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #876

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2025-06-30T22:31:20Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.05%. Comparing base (fef48c6) to head (bd3885d).
Report is 2 commits behind head on release-4.17.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.17     #883      +/-   ##
================================================
+ Coverage         47.03%   47.05%   +0.02%     
================================================
  Files                97       97              
  Lines             11828    11834       +6     
================================================
+ Hits               5563     5569       +6     
  Misses             5648     5648              
  Partials            617      617

Files with missing lines	Coverage Δ
...md/provisioning/azure/create_managed_identities.go	`57.80% <100.00%> (ø)`
pkg/cmd/provisioning/azure/create_oidc_issuer.go	`54.12% <100.00%> (+0.76%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jstuever · 2025-07-01T17:07:05Z

/retest

jstuever · 2025-07-01T17:07:57Z

/override ci/prow/security
This is unrelated and covered by another bug.

openshift-ci · 2025-07-01T17:10:50Z

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to this:

/override ci/prow/security
This is unrelated and covered by another bug.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jstuever · 2025-07-01T22:12:49Z

/lgtm
/approve
/label backport-risk-assessed
/override ci/prow/security

openshift-ci · 2025-07-01T22:13:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-07-01T22:13:45Z

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to this:

/lgtm
/approve
/label backport-risk-assessed
/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-07-01T22:13:48Z

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`bd3885d`	link	true	`/test security`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jianping-shu · 2025-07-02T06:29:11Z

pre-merge testing passed with cluster-bot build 4.17.0-0-2025-07-01-112701-test-ci-ln-s58llf2-latest.

Created the OIDC RG and storage account in advance and Azure Microsoft Entra Id cluster installed successfully and regression tests passed, OIDC RG and storage account didn't have the openshift.io_cloud-credential-operator tag any more.
part of ccoctl logs:
07-01 19:58:37.960 2025/07/01 11:58:37 Found existing resource group /subscriptions/<1-2-3-4-5>/resourceGroups/jshu76-rg-oidc
07-01 19:58:38.519 2025/07/01 11:58:38 Found existing storage account /subscriptions/<1-2-3-4-5>/resourceGroups/jshu76-rg-oidc/providers/Microsoft.Storage/storageAccounts/jshu76rgoidc

jianping-shu · 2025-07-02T06:29:38Z

/label cherry-pick-approved

jianping-shu · 2025-07-03T11:09:04Z

/jira refresh

openshift-ci-robot · 2025-07-03T11:09:13Z

@jianping-shu: This pull request references Jira Issue OCPBUGS-58248, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.17.z) matches configured target version for branch (4.17.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-58247 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-58247 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
bug has dependents

Requesting review from QA contact:
/cc @jianping-shu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-07-03T11:12:35Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-58248: All pull requests linked via external trackers have merged:

openshift/cloud-credential-operator#883

Jira Issue OCPBUGS-58248 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #876

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-07-03T13:13:10Z

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator
This PR has been included in build ose-cloud-credential-operator-container-v4.17.0-202507031236.p0.g6a80f0a.assembly.stream.el9.
All builds following this will include this PR.

openshift-cherrypick-robot assigned openshift-ci-robot Jun 30, 2025

openshift-cherrypick-robot mentioned this pull request Jun 30, 2025

OCPBUGS-53454: ccoctl: only add owned tag to azure resources on create #876

Merged

openshift-ci bot changed the title ~~[release-4.17] OCPBUGS-53454: ccoctl: only add owned tag to azure resources on create~~ [release-4.17] OCPBUGS-58248: ccoctl: only add owned tag to azure resources on create Jun 30, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 30, 2025

openshift-ci bot requested review from 2uasimojo and suhanime June 30, 2025 22:24

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 1, 2025

openshift-ci bot assigned jstuever Jul 1, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2025

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 2, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 3, 2025

openshift-ci bot requested a review from jianping-shu July 3, 2025 11:09

openshift-merge-bot bot merged commit 6a80f0a into openshift:release-4.17 Jul 3, 2025
13 checks passed

[release-4.17] OCPBUGS-58248: ccoctl: only add owned tag to azure resources on create #883

[release-4.17] OCPBUGS-58248: ccoctl: only add owned tag to azure resources on create #883

Uh oh!

Conversation

openshift-cherrypick-robot commented Jun 30, 2025

Uh oh!

openshift-ci-robot commented Jun 30, 2025

Uh oh!

openshift-ci-robot commented Jun 30, 2025

Uh oh!

codecov bot commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jstuever commented Jul 1, 2025

Uh oh!

jstuever commented Jul 1, 2025

Uh oh!

openshift-ci bot commented Jul 1, 2025

Uh oh!

jstuever commented Jul 1, 2025

Uh oh!

openshift-ci bot commented Jul 1, 2025

Uh oh!

openshift-ci bot commented Jul 1, 2025

Uh oh!

openshift-ci bot commented Jul 1, 2025

Uh oh!

jianping-shu commented Jul 2, 2025

Uh oh!

jianping-shu commented Jul 2, 2025

Uh oh!

jianping-shu commented Jul 3, 2025

Uh oh!

openshift-ci-robot commented Jul 3, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 3, 2025

Uh oh!

openshift-bot commented Jul 3, 2025

Uh oh!

Uh oh!

codecov bot commented Jun 30, 2025 •

edited

Loading