OCPBUGS-53454: ccoctl: only add owned tag to azure resources on create #876
Conversation
Prior to this change, ccoctl always added the owned tag to the resource groups and storage accounts. This caused errors when the number of owned tags from multpiple clusters exceeded the maximum tag limit. This change makes it so the owned tag is only added when a resource group or storage account is actually created. Any additional clusters using these resources will not attempt to add their own owned tag. This enables significantly more clusters to share the same resources without reaching the limit.
openshift-ci-robot
added
jira/valid-reference
|
@jstuever: This pull request references Jira Issue OCPBUGS-53454, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@jstuever: This pull request references Jira Issue OCPBUGS-53454, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/test e2e-azure-manual-oidc |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #876 +/- ##
==========================================
+ Coverage 46.97% 47.00% +0.02%
==========================================
Files 97 97
Lines 11910 11916 +6
==========================================
+ Hits 5595 5601 +6
Misses 5697 5697
Partials 618 618
🚀 New features to boost your workflow:
|
|
/retest |
|
/retest |
|
/assign @mold |
|
@jstuever: GitHub didn't allow me to assign the following users: mold. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/assign @dlom |
|
pre-merge testing passed with cluster-bot build.
|
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlom, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/jira backport release-4.19,release-4.18,release-4.17 |
|
@jstuever: The following backport issues have been created:
Queuing cherrypicks to the requested branches to be created after this PR merges: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jstuever: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@jstuever: Jira Issue OCPBUGS-53454: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-53454 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: new pull request created: #881 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci-robot: new pull request created: #882 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci-robot: new pull request created: #883 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cloud-credential-operator |
Prior to this change, ccoctl always added the owned tag to the resource groups and storage accounts. This caused errors when the number of owned tags from multpiple clusters exceeded the maximum tag limit.
This change makes it so the owned tag is only added when a resource group or storage account is actually created. Any additional clusters using these resources will not attempt to add their own owned tag. This enables significantly more clusters to share the same resources without reaching the limit.