Skip to content

CCO-685: Add retry logic for Azure federated identity credential creation #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaovilai
Copy link
Member

Add retry logic to handle ParentResourceNotFound errors when creating
federated identity credentials in Azure. This addresses Azure's eventual
consistency issue where managed identities aren't immediately available
across all API endpoints after creation.

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

…tion

Add retry logic to handle ParentResourceNotFound errors when creating
federated identity credentials in Azure. This addresses Azure's eventual
consistency issue where managed identities aren't immediately available
across all API endpoints after creation.

- Retry up to 24 times with 10-second delays (4 minutes total)
- Specifically handle ParentResourceNotFound error code
- Similar to the retry logic added for role assignments in PR openshift#781

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 26, 2025

@kaovilai: This pull request references CCO-685 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Add retry logic to handle ParentResourceNotFound errors when creating
federated identity credentials in Azure. This addresses Azure's eventual
consistency issue where managed identities aren't immediately available
across all API endpoints after creation.

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from 2uasimojo and jstuever June 26, 2025 16:00
Copy link
Contributor

openshift-ci bot commented Jun 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kaovilai
Once this PR has been reviewed and has the lgtm label, please assign jstuever for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstuever jstuever self-assigned this Jun 26, 2025
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 44.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 46.94%. Comparing base (57e1b35) to head (f5c7023).

Files with missing lines Patch % Lines
...md/provisioning/azure/create_managed_identities.go 44.00% 13 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #878      +/-   ##
==========================================
- Coverage   46.97%   46.94%   -0.03%     
==========================================
  Files          97       97              
  Lines       11910    11926      +16     
==========================================
+ Hits         5595     5599       +4     
- Misses       5697     5709      +12     
  Partials      618      618              
Files with missing lines Coverage Δ
...md/provisioning/azure/create_managed_identities.go 56.73% <44.00%> (-1.08%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kaovilai
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented Jun 26, 2025

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants