Skip to content

OCPBUGS-44933: Add retry to ccoctl gcp create functions #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

jstuever
Copy link
Contributor

The ccoct gcp create functions occassionaly fail when recently created resources have not yet replicated in the cloud. This change adds retry functionality to increase success rate when this happens.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 25, 2024
@openshift-ci-robot
Copy link
Contributor

@jstuever: This pull request references Jira Issue OCPBUGS-44933, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The ccoct gcp create functions occassionaly fail when recently created resources have not yet replicated in the cloud. This change adds retry functionality to increase success rate when this happens.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dlom and suhanime November 25, 2024 21:24
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 20 lines in your changes missing coverage. Please review.

Project coverage is 46.99%. Comparing base (166901d) to head (70d1772).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...kg/cmd/provisioning/gcp/create_service_accounts.go 23.07% 9 Missing and 1 partial ⚠️
...visioning/gcp/create_workload_identity_provider.go 28.57% 9 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   47.03%   46.99%   -0.05%     
==========================================
  Files          97       97              
  Lines       11835    11856      +21     
==========================================
+ Hits         5567     5572       +5     
- Misses       5655     5671      +16     
  Partials      613      613              
Files with missing lines Coverage Δ
...md/provisioning/azure/create_managed_identities.go 57.71% <100.00%> (ø)
...kg/cmd/provisioning/gcp/create_service_accounts.go 52.50% <23.07%> (-1.31%) ⬇️
...visioning/gcp/create_workload_identity_provider.go 49.42% <28.57%> (-1.50%) ⬇️

@jstuever
Copy link
Contributor Author

/jira backport release-4.18,release-4.17,release-4.16,release-4.15,release-4.14

@openshift-ci-robot
Copy link
Contributor

@jstuever: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18
/cherrypick release-4.17
/cherrypick release-4.16
/cherrypick release-4.15
/cherrypick release-4.14

In response to this:

/jira backport release-4.18,release-4.17,release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.14, release-4.15, release-4.16, release-4.17, release-4.18 in new PRs and assign them to you.

In response to this:

@jstuever: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18
/cherrypick release-4.17
/cherrypick release-4.16
/cherrypick release-4.15
/cherrypick release-4.14

In response to this:

/jira backport release-4.18,release-4.17,release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstuever
Copy link
Contributor Author

/retest

2 similar comments
@jstuever
Copy link
Contributor Author

/retest

@jstuever
Copy link
Contributor Author

/retest

@huangmingxia
Copy link

Verified pass with build: registry.build05.ci.openshift.org/ci-ln-hjs9s92/release:latest
When creating resources with ccoctl, will retry if any delays occur.

11-27 16:46:13.814  [INFO] Creating workload identity and IAM roles
11-27 16:46:13.815  Running Command: ./ccoctl gcp create-all  --name='mihuang11273-24430' --project 'openshift-qe' --region='us-central1' --credentials-requests-dir='/home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/cco-cred-requests' --output-dir '/home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts'
11-27 16:46:13.815  2024/11/27 08:46:12 Credentials loaded from environment variable "GOOGLE_CREDENTIALS", file "/home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/gcpcreds20241127-270-u02eof"
11-27 16:46:13.815  2024/11/27 08:46:12 Generating RSA keypair
11-27 16:46:17.967  2024/11/27 08:46:17 Writing private key to /home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts/serviceaccount-signer.private
11-27 16:46:17.967  2024/11/27 08:46:17 Writing public key to /home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts/serviceaccount-signer.public
11-27 16:46:17.967  2024/11/27 08:46:17 Copying signing key for use by installer
11-27 16:46:18.221  2024/11/27 08:46:18 Workload identity pool created with name mihuang11273-24430
11-27 16:46:18.780  2024/11/27 08:46:18 Bucket mihuang11273-24430-oidc created
11-27 16:46:19.337  2024/11/27 08:46:19 Bucket mihuang11273-24430-oidc is set to be publicly readable
11-27 16:46:19.591  2024/11/27 08:46:19 OpenID Connect discovery document in the S3 bucket mihuang11273-24430-oidc at .well-known/openid-configuration updated
11-27 16:46:19.592  2024/11/27 08:46:19 Reading public key
11-27 16:46:19.592  2024/11/27 08:46:19 JSON web key set (JWKS) in the S3 bucket mihuang11273-24430-oidc at keys.json updated
11-27 16:46:20.151  2024/11/27 08:46:20 workload identity provider created with name mihuang11273-24430
11-27 16:46:20.152  2024/11/27 08:46:20 Wrote cluster authentication manifest at path /home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts/manifests/cluster-authentication-02-config.yaml
11-27 16:46:20.152  2024/11/27 08:46:20 Issuer URL (serviceAccountIssuer) is https://storage.googleapis.com/mihuang11273-24430-oidc
11-27 16:46:20.152  2024/11/27 08:46:20 Ignoring CredentialsRequest openshift-cloud-credential-operator/openshift-cluster-api-gcp with tech-preview annotation
11-27 16:46:26.687  2024/11/27 08:46:26 IAM service account mihuang11273-24430-openshift-gcp-ccm created
11-27 16:46:26.687  2024/11/27 08:46:26 Existing IAM custom role openshift-qe-openshift-gcp-ccm found, updating permissions
11-27 16:46:28.046  2024/11/27 08:46:27 Unable to add predefined roles to IAM service account, retrying...
11-27 16:46:40.195  2024/11/27 08:46:40 Updated policy bindings for IAM service account mihuang11273-24430-openshift-gcp-ccm
11-27 16:46:40.195  2024/11/27 08:46:40 Saved credentials configuration to: /home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts/manifests/openshift-cloud-controller-manager-gcp-ccm-cloud-credentials-credentials.yaml
11-27 16:46:46.712  2024/11/27 08:46:46 IAM service account mihuang11273-24430-openshift-machine-api-gcp created
11-27 16:46:46.712  2024/11/27 08:46:46 Existing IAM custom role openshift-qe-openshift-machine-api-gcp found, updating permissions
11-27 16:46:46.713  2024/11/27 08:46:46 Unexpected permissions found on existing custom role openshift-qe-openshift-machine-api-gcp: compute.instanceGroups.use
11-27 16:46:48.071  2024/11/27 08:46:47 Unable to add predefined roles to IAM service account, retrying...
11-27 16:47:00.222  2024/11/27 08:46:59 Updated policy bindings for IAM service account mihuang11273-24430-openshift-machine-api-gcp
11-27 16:47:00.222  2024/11/27 08:46:59 Saved credentials configuration to: /home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts/manifests/openshift-machine-api-gcp-cloud-credentials-credentials.yaml
11-27 16:47:06.749  2024/11/27 08:47:06 IAM service account mihuang11273-24430-cloud-credential-operator-gcp-ro-creds created
11-27 16:47:06.749  2024/11/27 08:47:06 Existing IAM custom role openshift-qe-cloud-credential-operator-gcp-ro-creds found, updating permissions
11-27 16:47:06.749  2024/11/27 08:47:06 Unexpected permissions found on existing custom role openshift-qe-cloud-credential-operator-gcp-ro-creds: iam.roles.list
11-27 16:47:08.631  2024/11/27 08:47:08 Updated policy bindings for IAM service account mihuang11273-24430-cloud-credential-operator-gcp-ro-creds
11-27 16:47:08.631  2024/11/27 08:47:08 Saved credentials configuration to: /home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts/manifests/openshift-cloud-credential-operator-cloud-credential-operator-gcp-ro-creds-credentials.yaml
11-27 16:47:15.152  2024/11/27 08:47:14 IAM service account mihuang11273-24430-openshift-image-registry-gcs created
11-27 16:47:15.152  2024/11/27 08:47:14 Existing IAM custom role openshift-qe-openshift-image-registry-gcs found, updating permissions
11-27 16:47:17.657  2024/11/27 08:47:17 Updated policy bindings for IAM service account mihuang11273-24430-openshift-image-registry-gcs
11-27 16:47:17.658  2024/11/27 08:47:17 Saved credentials configuration to: /home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts/manifests/openshift-image-registry-installer-cloud-credentials-credentials.yaml
11-27 16:47:24.202  2024/11/27 08:47:23 IAM service account mihuang11273-24430-openshift-ingress-gcp created
11-27 16:47:24.202  2024/11/27 08:47:24 Existing IAM custom role openshift-qe-openshift-ingress-gcp found, updating permissions
11-27 16:47:26.733  2024/11/27 08:47:26 Updated policy bindings for IAM service account mihuang11273-24430-openshift-ingress-gcp
11-27 16:47:26.733  2024/11/27 08:47:26 Saved credentials configuration to: /home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts/manifests/openshift-ingress-operator-cloud-credentials-credentials.yaml
11-27 16:47:33.253  2024/11/27 08:47:32 IAM service account mihuang11273-24430-openshift-cloud-network-config-controller-gcp created
11-27 16:47:33.253  2024/11/27 08:47:32 Existing IAM custom role openshift-qe-openshift-cloud-network-config-controller-gcp found, updating permissions
11-27 16:47:33.811  2024/11/27 08:47:33 Unable to add predefined roles to IAM service account, retrying...
11-27 16:47:48.626  2024/11/27 08:47:45 Updated policy bindings for IAM service account mihuang11273-24430-openshift-cloud-network-config-controller-gcp
11-27 16:47:48.626  2024/11/27 08:47:45 Saved credentials configuration to: /home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts/manifests/openshift-cloud-network-config-controller-cloud-credentials-credentials.yaml
11-27 16:47:52.780  2024/11/27 08:47:51 IAM service account mihuang11273-24430-openshift-gcp-pd-csi-driver-operator created
11-27 16:47:52.781  2024/11/27 08:47:52 Existing IAM custom role openshift-qe-openshift-gcp-pd-csi-driver-operator found, updating permissions
11-27 16:47:55.285  2024/11/27 08:47:54 Updated policy bindings for IAM service account mihuang11273-24430-openshift-gcp-pd-csi-driver-operator
11-27 16:47:55.285  2024/11/27 08:47:54 Saved credentials configuration to: /home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/workdir/install-dir/pre_action/sts/manifests/openshift-cluster-csi-drivers-gcp-pd-cloud-credentials-credentials.yaml

11-27 17:34:03.918  NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
11-27 17:34:03.918  version   4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         6m38s   Cluster version is 4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest
11-27 17:34:03.918  NAME                                       VERSION                                                   AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
11-27 17:34:03.918  authentication                             4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      7m9s    
11-27 17:34:03.918  baremetal                                  4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      30m     
11-27 17:34:03.918  cloud-controller-manager                   4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      34m     
11-27 17:34:03.918  cloud-credential                           4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      30m     
11-27 17:34:03.919  cluster-autoscaler                         4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      30m     
11-27 17:34:03.919  config-operator                            4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      32m     
11-27 17:34:03.919  console                                    4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      15m     
11-27 17:34:03.919  control-plane-machine-set                  4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      27m     
11-27 17:34:03.919  csi-snapshot-controller                    4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      31m     
11-27 17:34:03.919  dns                                        4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      30m     
11-27 17:34:03.920  etcd                                       4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      30m     
11-27 17:34:03.920  image-registry                             4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      22m     
11-27 17:34:03.920  ingress                                    4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      21m     
11-27 17:34:03.920  insights                                   4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      31m     
11-27 17:34:03.920  kube-apiserver                             4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      28m     
11-27 17:34:03.920  kube-controller-manager                    4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      28m     
11-27 17:34:03.920  kube-scheduler                             4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      28m     
11-27 17:34:03.921  kube-storage-version-migrator              4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      32m     
11-27 17:34:03.921  machine-api                                4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      24m     
11-27 17:34:03.921  machine-approver                           4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      30m     
11-27 17:34:03.921  machine-config                             4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      30m     
11-27 17:34:03.921  marketplace                                4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      30m     
11-27 17:34:03.921  monitoring                                 4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      13m     
11-27 17:34:03.922  network                                    4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      34m     
11-27 17:34:03.922  node-tuning                                4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      24m     
11-27 17:34:03.922  olm                                        4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      31m     
11-27 17:34:03.922  openshift-apiserver                        4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      22m     
11-27 17:34:03.922  openshift-controller-manager               4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      26m     
11-27 17:34:03.922  openshift-samples                          4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      22m     
11-27 17:34:03.922  operator-lifecycle-manager                 4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      30m     
11-27 17:34:03.923  operator-lifecycle-manager-catalog         4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      30m     
11-27 17:34:03.923  operator-lifecycle-manager-packageserver   4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      17m     
11-27 17:34:03.923  service-ca                                 4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      32m     
11-27 17:34:03.923  storage                                    4.18.0-0.ci.test-2024-11-27-084055-ci-ln-hjs9s92-latest   True        False         False      31m     
11-27 17:34:03.923  NAME     CONFIG                                             UPDATED   UPDATING   DEGRADED   MACHINECOUNT   READYMACHINECOUNT   UPDATEDMACHINECOUNT   DEGRADEDMACHINECOUNT   AGE
11-27 17:34:03.923  master   rendered-master-63bf32318de9db1486b19b0f7b45c926   True      False      False      3              3                   3                     0                      31m
11-27 17:34:03.924  worker   rendered-worker-0c0873abdebaa4b49c79a0339c3876df   True      False      False      3              3                   3                     0                      31m

@jstuever
Copy link
Contributor Author

/assign @dlom

The ccoct gcp create functions occassionaly fail when recently created
resources have not yet replicated in the cloud. This change adds retry
functionality to increase success rate when this happens.
@jstuever
Copy link
Contributor Author

jstuever commented Dec 3, 2024

/test e2e-gcp-manual-oidc

@jstuever jstuever requested a review from dlom December 3, 2024 19:00
@dlom
Copy link
Contributor

dlom commented Dec 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
Copy link
Contributor

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 97bdae4 and 2 for PR HEAD 70d1772 in total

@jianping-shu
Copy link

/test e2e-azure-manual-oidc

@huangmingxia
Copy link

/test ci/prow/okd-scos-e2e-aws-ovn

Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

@huangmingxia: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test coverage
/test e2e-aws-ovn
/test e2e-azure-manual-oidc
/test e2e-hypershift
/test e2e-upgrade
/test images
/test security
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-aws-manual-oidc
/test e2e-aws-qe
/test e2e-azure
/test e2e-azure-upgrade
/test e2e-gcp
/test e2e-gcp-manual-oidc
/test e2e-openstack
/test e2e-openstack-parallel
/test okd-scos-e2e-aws-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cloud-credential-operator-master-coverage
pull-ci-openshift-cloud-credential-operator-master-e2e-aws-ovn
pull-ci-openshift-cloud-credential-operator-master-e2e-aws-qe
pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc
pull-ci-openshift-cloud-credential-operator-master-e2e-hypershift
pull-ci-openshift-cloud-credential-operator-master-e2e-upgrade
pull-ci-openshift-cloud-credential-operator-master-images
pull-ci-openshift-cloud-credential-operator-master-okd-scos-e2e-aws-ovn
pull-ci-openshift-cloud-credential-operator-master-security
pull-ci-openshift-cloud-credential-operator-master-unit
pull-ci-openshift-cloud-credential-operator-master-verify
pull-ci-openshift-cloud-credential-operator-master-verify-deps

In response to this:

/test ci/prow/okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@huangmingxia
Copy link

/test okd-scos-e2e-aws-ovn

@openshift-merge-bot openshift-merge-bot bot merged commit 33e90d6 into openshift:master Dec 4, 2024
13 of 14 checks passed
@openshift-ci-robot
Copy link
Contributor

@jstuever: Jira Issue OCPBUGS-44933: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44933 has been moved to the MODIFIED state.

In response to this:

The ccoct gcp create functions occassionaly fail when recently created resources have not yet replicated in the cloud. This change adds retry functionality to increase success rate when this happens.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@openshift-ci-robot: new pull request created: #791

In response to this:

@jstuever: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18
/cherrypick release-4.17
/cherrypick release-4.16
/cherrypick release-4.15
/cherrypick release-4.14

In response to this:

/jira backport release-4.18,release-4.17,release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@openshift-ci-robot: new pull request created: #792

In response to this:

@jstuever: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18
/cherrypick release-4.17
/cherrypick release-4.16
/cherrypick release-4.15
/cherrypick release-4.14

In response to this:

/jira backport release-4.18,release-4.17,release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@openshift-ci-robot: new pull request created: #793

In response to this:

@jstuever: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18
/cherrypick release-4.17
/cherrypick release-4.16
/cherrypick release-4.15
/cherrypick release-4.14

In response to this:

/jira backport release-4.18,release-4.17,release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@openshift-ci-robot: new pull request created: #794

In response to this:

@jstuever: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18
/cherrypick release-4.17
/cherrypick release-4.16
/cherrypick release-4.15
/cherrypick release-4.14

In response to this:

/jira backport release-4.18,release-4.17,release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@openshift-ci-robot: new pull request created: #795

In response to this:

@jstuever: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18
/cherrypick release-4.17
/cherrypick release-4.16
/cherrypick release-4.15
/cherrypick release-4.14

In response to this:

/jira backport release-4.18,release-4.17,release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator
This PR has been included in build ose-cloud-credential-operator-container-v4.19.0-202412040917.p0.g33e90d6.assembly.stream.el9.
All builds following this will include this PR.

@jstuever jstuever deleted the OCPBUGS-44933 branch April 9, 2025 17:23
kaovilai added a commit to kaovilai/cloud-credential-operator that referenced this pull request Jun 26, 2025
…tion

Add retry logic to handle ParentResourceNotFound errors when creating
federated identity credentials in Azure. This addresses Azure's eventual
consistency issue where managed identities aren't immediately available
across all API endpoints after creation.

- Retry up to 24 times with 10-second delays (4 minutes total)
- Specifically handle ParentResourceNotFound error code
- Similar to the retry logic added for role assignments in PR openshift#781

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants