This repository was archived by the owner on Jul 11, 2023. It is now read-only.
(backport/v1.2.3) Allow all headless services, not just those backed by Statefulsets with subdomains (#5250) #5263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithmattix
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio,
trstringer and
steeling
as code owners
…th subdomains (openservicemesh#5250) * Allow all headless services, not just those backed by Statefulsets with subdomains Signed-off-by: Keith Mattix II <[email protected]>
keithmattix
force-pushed
the
release-v1.2
branch
from
edd78e9 to
25c8e53
Compare
Codecov Report
@@ Coverage Diff @@
## release-v1.2 #5263 +/- ##
================================================
+ Coverage 68.81% 68.84% +0.02%
================================================
Files 210 210
Lines 15668 15679 +11
================================================
+ Hits 10782 10794 +12
+ Misses 4835 4834 -1
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
) Due to the project guidelines on [inactivity](https://github.com/openservicemesh/osm/blob/main/CONTRIBUTOR_LADDER.md#inactivity), this PR proposes moving @snehachhabria and @draychev to emeritus status. Thank you for your contributions to this project! Signed-off-by: Thomas Stringer <[email protected]>
@shalier has been contributing to the project at the level that is expected of a maintainer. Maintainers, if you agree with this nomination, leave a "+1" comment and approve the PR (do not merge it). Signed-off-by: Thomas Stringer <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
jaellio
previously approved these changes
Dec 12, 2022
*Upgrade cert-manager to v1.10.0 Signed-off-by: Keith Mattix II <[email protected]>
keithmattix
force-pushed
the
release-v1.2
branch
7 times, most recently
from
f741c31 to
d14ef62
Compare
bump version of go to 1.19 Signed-off-by: Sean Teeling <[email protected]>
keithmattix
force-pushed
the
release-v1.2
branch
from
d14ef62 to
8ed34f8
Compare
jaellio
approved these changes
Dec 13, 2022
shalier
approved these changes
Dec 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to add some formatting and such to cherry-picks to make the linter work with Go 1.19 and thew new cert-manager versions
Signed-off-by: Keith Mattix II [email protected]