This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Allow all headless services, not just those backed by Statefulsets with subdomains #5250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th subdomains Signed-off-by: Keith Mattix II <[email protected]>
keithmattix
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio,
trstringer and
steeling
as code owners
steeling
approved these changes
Nov 11, 2022
shashankram
approved these changes
Nov 11, 2022
Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
keithmattix
deleted the
add-headless-service-in-addition-to-endpoint-hostnames
branch
keithmattix
added a commit
to keithmattix/osm
that referenced
this pull request
Dec 8, 2022
…th subdomains (openservicemesh#5250) * Allow all headless services, not just those backed by Statefulsets with subdomains Signed-off-by: Keith Mattix II <[email protected]>
keithmattix
added a commit
to keithmattix/osm
that referenced
this pull request
Dec 8, 2022
…th subdomains (openservicemesh#5250) * Allow all headless services, not just those backed by Statefulsets with subdomains Signed-off-by: Keith Mattix II <[email protected]>
keithmattix
added a commit
that referenced
this pull request
Dec 14, 2022
(backport/v1.2.3) Allow all headless services, not just those backed by Statefulsets with subdomains (#5250)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic requires
hostnameto be set before aMeshServiceis created from a headless service's endpoint. However,hostnameis only populated on the endpoint when that endpoint is generated from a StatefulSet.This PR creates a MeshService for every service so that it's still resolvable via DNS (instead of kube-proxy like ClusterIP services).Creating a
MeshServicefor every headless service creates an issue if there is indeed a subdomain statefulset behind the headless service. Therefore, we only created a separate MeshService if the headless service it came from doesn't have a hostName in at least one of its endpoints