This repository was archived by the owner on Jul 11, 2023. It is now read-only.
feat(certs): use MeshConfig feature flag to enable MRC #5204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaellio
force-pushed
the
addEnableMRCFeatureFlag
branch
from
3b99920 to
40b2c33
Compare
jaellio
force-pushed
the
addEnableMRCFeatureFlag
branch
2 times, most recently
from
bcccee7 to
a78c5c4
Compare
jaellio
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
trstringer,
keithmattix and
steeling
as code owners
jaellio
force-pushed
the
addEnableMRCFeatureFlag
branch
4 times, most recently
from
cd716f6 to
d772ecc
Compare
keithmattix
reviewed
Nov 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #5204 +/- ##
==========================================
- Coverage 70.33% 70.30% -0.04%
==========================================
Files 195 195
Lines 15694 15697 +3
==========================================
- Hits 11038 11035 -3
- Misses 4601 4607 +6
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jaellio
force-pushed
the
addEnableMRCFeatureFlag
branch
from
6ffa86a to
dbe3021
Compare
jaellio
commented
Nov 11, 2022
jaellio
force-pushed
the
addEnableMRCFeatureFlag
branch
from
1bde043 to
673d8b5
Compare
jaellio
force-pushed
the
addEnableMRCFeatureFlag
branch
from
d39a3ac to
2a867cb
Compare
jsturtevant
approved these changes
Nov 16, 2022
keithmattix
approved these changes
Nov 16, 2022
steeling
approved these changes
Nov 19, 2022
| // shouldCreateMeshRootCertificate gets the MeshConfig and returns the values of the enableMeshRootCertificate | ||
| // feature flag | ||
| func (b *bootstrap) shouldCreateMeshRootCertificate() bool { | ||
| config, err := b.configClient.ConfigV1alpha2().MeshConfigs(b.namespace).Get(context.TODO(), meshConfigName, metav1.GetOptions{}) |
There was a problem hiding this comment.
can we have this also check if a meshRootCertificate already exists? If there are any we should not create a new one.
There was a problem hiding this comment.
Renamed method to shouldEnsureMeshRootCertificate. The logic to check for an existing active MRCs is in ensureMeshRootCertificate.
Replace binary flag with MeshConfig feature flag to enable the use of the MRC. If OSM has been installed with EnableMeshRootCertificate disabled, if the feature flag is then enabled in the MeshConfig the control plane components must be restarted in order to pick up on the enabled flag, and begin using the MRC for certificate management. Signed-off-by: jaellio <[email protected]>
Signed-off-by: jaellio <[email protected]>
enableMeshRootCertificate feature flag Signed-off-by: jaellio <[email protected]>
Signed-off-by: jaellio <[email protected]>
and restart bootstrap before controller and injector. Signed-off-by: jaellio <[email protected]>
Signed-off-by: jaellio <[email protected]>
Signed-off-by: jaellio <[email protected]>
Signed-off-by: jaellio <[email protected]>
Signed-off-by: jaellio <[email protected]>
Signed-off-by: jaellio <[email protected]>
Signed-off-by: jaellio <[email protected]>
jaellio
force-pushed
the
addEnableMRCFeatureFlag
branch
from
2a867cb to
54136bd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Replace binary flag with MeshConfig feature flag to enable the use
of the MRC. If OSM has been installed with
EnableMeshRootCertificate disabled, if the feature flag is then
enabled in the MeshConfig the control plane components must be
restarted in order to pick up on the enabled flag, and begin using
the MRC for certificate management.
Adds an e2e to check enabling the MRC after osm install for each
cert provider.
Dependent on #5201
Resolves #5041
Part of #4835
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? no
Is this a breaking change? no
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? no