-
Notifications
You must be signed in to change notification settings - Fork 276
Support for root certificate rotation via CLI #5207
Conversation
55b29b3
to
ef1b901
Compare
This also partially addresses #5207, which was needed to be able to test rotation to vault from other providers. |
c87d682
to
045d8cc
Compare
This command consists of multiple subcommands related that are in alpha. | ||
` | ||
|
||
func newAlphaCmd(out io.Writer) *cobra.Command { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any other OSM CLI commands that we would characterize as "alpha" or could "preview" just be added in a warning for the command's help and output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question, I am up for either and easy change to make. I modeled it after kubectl alpha
which I like because it is very clear that is experimental when using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach, but I am curious to see what other maintainers think.
045d8cc
to
30bb9d4
Compare
Codecov Report
@@ Coverage Diff @@
## main #5207 +/- ##
==========================================
- Coverage 70.30% 69.35% -0.95%
==========================================
Files 195 198 +3
Lines 15697 15994 +297
==========================================
+ Hits 11035 11093 +58
- Misses 4607 4844 +237
- Partials 55 57 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
0f81f9f
to
6af30bf
Compare
Signed-off-by: James Sturtevant <[email protected]>
6af30bf
to
abbcdb2
Compare
Signed-off-by: James Sturtevant <[email protected]>
bb3aefd
to
7034646
Compare
Signed-off-by: James Sturtevant <[email protected]>
Description:
This build on #5201 (required before this) to provide alpha support for rotation in the CLI. This is a proposal for adding a command to ease the burden of managing the MRCs and adds several tests for trust domain and switching between providers.
example usage would be:
Resolves #4835
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?