This repository was archived by the owner on Jul 11, 2023. It is now read-only.
demo/scripts: fix bookstore app label and container name #4910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the scripts to be in sync with the manifests used in the manual demo documented on the website and to be compatible with changes made to the bookstore app labels in 5f54056. Also fixes openservicemesh#4906 and updates the release notes for v1.2. Signed-off-by: Shashank Ram <[email protected]>
shashankram
requested review from
snehachhabria,
nojnhuh,
draychev,
jaellio,
trstringer,
keithmattix and
steeling
as code owners
keithmattix
reviewed
Jul 18, 2022
nojnhuh
approved these changes
Jul 18, 2022
jaellio
approved these changes
Jul 18, 2022
keithmattix
approved these changes
Jul 18, 2022
shashankram
added a commit
to shashankram/osm
that referenced
this pull request
Jul 18, 2022
…mesh#4910) Updates the scripts to be in sync with the manifests used in the manual demo documented on the website and to be compatible with changes made to the bookstore app labels in 5f54056. Also fixes openservicemesh#4906 and updates the release notes for v1.2. Signed-off-by: Shashank Ram <[email protected]>
shashankram
added a commit
that referenced
this pull request
Jul 18, 2022
[backport] demo/scripts: fix bookstore app label and container name (#4910)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates the scripts to be in sync with the manifests
used in the manual demo documented on the website and
to be compatible with changes made to the bookstore app
labels in 5f54056.
Also fixes #4906 and updates the release notes for
v1.2.
Testing done:
Ran the demo and scripts
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
noHas documentation corresponding to this change been updated in the osm-docs repo (if applicable)? yes