Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Bug in Getting Started (https://release-v1-1.docs.openservicemesh.io/docs/getting_started/install_apps/#view-the-application-uis) #4906

Closed
mifurm opened this issue Jul 17, 2022 · 2 comments · Fixed by #4910
Closed

Bug in Getting Started (https://release-v1-1.docs.openservicemesh.io/docs/getting_started/install_apps/#view-the-application-uis) #4906

mifurm opened this issue Jul 17, 2022 · 2 comments · Fixed by #4910
Assignees
@shashankram

Comments

@mifurm
Copy link

mifurm commented Jul 17, 2022

Please describe what should be documented
In the section (View the Application UI) of OSM you refer to ./scripts/port-forward-all.sh script. The script is using set of other forward scripts, one for bookstore (./scripts/port-forward-bookstore-ui-v1.sh). The bookstore script is looking for pod with label bookstore-v1 while there is no such app in the cluster.
Please suggest where in the repo the document should be located
The script ./scripts/port-forward-bookstore-ui-v1.sh should refer to the pod with label bookstore, not bookstore-v1.
@shashankram shashankram self-assigned this Jul 18, 2022
@shashankram
Copy link
Member

@mifurm Yes this due to a recent change in main regarding labels on the bookstore app + service. Will fix this on main.

@shashankram
Copy link
Member

@mifurm Yes this due to a recent change in main regarding labels on the bookstore app + service. Will fix this on main.

Never mind, figured this is an existing issue unrelated to the recent change I made. Will fix this along with the other labeling changes to the app manifests and scripts.

shashankram added a commit to shashankram/osm that referenced this issue Jul 18, 2022
@shashankram
demo/scripts: fix bookstore app label and container name
858d6b5 
Updates the scripts to be in sync with the manifests
used in the manual demo documented on the website and
to be compatible with changes made to the bookstore app
labels in 5f54056.

Also fixes openservicemesh#4906 and updates the release notes for
v1.2.

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram mentioned this issue Jul 18, 2022
Merged
shashankram added a commit that referenced this issue Jul 18, 2022
@shashankram
demo/scripts: fix bookstore app label and container name (#4910)
e94c48b 
Updates the scripts to be in sync with the manifests
used in the manual demo documented on the website and
to be compatible with changes made to the bookstore app
labels in 5f54056.

Also fixes #4906 and updates the release notes for
v1.2.

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to shashankram/osm that referenced this issue Jul 18, 2022
@shashankram
demo/scripts: fix bookstore app label and container name (openservice…
9749020 
…mesh#4910)

Updates the scripts to be in sync with the manifests
used in the manual demo documented on the website and
to be compatible with changes made to the bookstore app
labels in 5f54056.

Also fixes openservicemesh#4906 and updates the release notes for
v1.2.

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram mentioned this issue Jul 18, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shashankram shashankram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

demo/scripts: fix bookstore app label and container name shashankram/osm
2 participants
@mifurm @shashankram