This repository was archived by the owner on Jul 11, 2023. It is now read-only.
fix: update configClient call and logging #4854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes incorrect configClient call and removes log definition. Signed-off-by: jaellio <[email protected]>
jaellio
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev and
trstringer
as code owners
nojnhuh
approved these changes
Jun 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #4854 +/- ##
==========================================
+ Coverage 69.34% 69.51% +0.17%
==========================================
Files 219 219
Lines 16012 16033 +21
==========================================
+ Hits 11104 11146 +42
+ Misses 4854 4833 -21
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
keithmattix
reviewed
Jun 28, 2022
pkg/certificate/providers/types.go
Outdated
| ) | ||
|
|
||
| var log = logger.New("certificate/provider") |
There was a problem hiding this comment.
I was seeing lint errors here baff85f
There was a problem hiding this comment.
Ah, in that case, we should remove (or alias) the import and keep this line; this assignment adds good context to the log lines
shashankram
approved these changes
Jun 28, 2022
Signed-off-by: jaellio <[email protected]>
keithmattix
approved these changes
Jun 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes incorrect configClient call and removes log definition.
Testing done: