Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Commit d970b24

Browse files
authored
fix: update configClient call and logging (#4854)
Fixes incorrect configClient call and uses logger instead of zerolog in certificate/provider Signed-off-by: jaellio <[email protected]>
1 parent baff85f commit d970b24

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

pkg/certificate/providers/config_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ func TestGetCertificateManager(t *testing.T) {
136136
},
137137
}),
138138
informerCollectionFunc: func(tc testCase) (*informers.InformerCollection, error) {
139-
ic, err := informers.NewInformerCollection("osm", nil, informers.WithKubeClient(tc.kubeClient), informers.WithConfigClient(tc.configClient))
139+
ic, err := informers.NewInformerCollection("osm", nil, informers.WithKubeClient(tc.kubeClient), informers.WithConfigClient(tc.configClient, "", "osm-system"))
140140
if err != nil {
141141
return nil, err
142142
}
@@ -196,7 +196,7 @@ func TestGetCertificateManager(t *testing.T) {
196196
},
197197
}),
198198
informerCollectionFunc: func(tc testCase) (*informers.InformerCollection, error) {
199-
ic, err := informers.NewInformerCollection("osm", nil, informers.WithKubeClient(tc.kubeClient), informers.WithConfigClient(tc.configClient, "", "osm-namespace"))
199+
ic, err := informers.NewInformerCollection("osm", nil, informers.WithKubeClient(tc.kubeClient), informers.WithConfigClient(tc.configClient, "", "osm-system"))
200200
if err != nil {
201201
return nil, err
202202
}

pkg/certificate/providers/mrc.go

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package providers
33
import (
44
"context"
55

6-
"github.com/rs/zerolog/log"
76
"k8s.io/client-go/tools/cache"
87

98
"github.com/openservicemesh/osm/pkg/apis/config/v1alpha2"

0 commit comments

Comments
 (0)