This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Fix failing e2es with GinkgoRecover and resolve CVE-2022-28948 #4832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup will be skipped and test will exit bypassing cleanup if a different context goroutine panics or asserts without deferring the ginkgo recover function. Related to openservicemesh#3119 Signed-off-by: jaellio <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4832 +/- ##
==========================================
- Coverage 69.47% 69.46% -0.02%
==========================================
Files 218 218
Lines 15766 15766
==========================================
- Hits 10954 10952 -2
- Misses 4760 4762 +2
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: jaellio <[email protected]>
jaellio
changed the title
Signed-off-by: jaellio <[email protected]>
Signed-off-by: jaellio <[email protected]>
jaellio
changed the title
jaellio
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev and
trstringer
as code owners
allenlsy
approved these changes
Jun 20, 2022
shalier
approved these changes
Jun 20, 2022
nojnhuh
approved these changes
Jun 21, 2022
trstringer
approved these changes
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
GinkgoRecover()to e2e go routines. Cleanup willbe skipped and test will exit bypassing cleanup if a
different context goroutine panics or asserts without
deferring the ginkgo recover function.
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?