This repository was archived by the owner on Jul 11, 2023. It is now read-only.
e2e: fix ginkgo panic recoveries #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup will be skipped and test will exit bypassing cleanup if a different context goroutine panics or asserts without deferring the ginkgo recover function. This causes logs to not be collected in some situations (ie, when a test has some goroutines waiting for NS to come up but they don't). Signed-off-by: edu <[email protected]>
eduser25
force-pushed
the
test-fix-branch
branch
from
157c2cf to
a22e363
Compare
shashankram
approved these changes
Apr 9, 2021
nshankar13
approved these changes
Apr 9, 2021
jaellio
added a commit
to jaellio/osm
that referenced
this pull request
Jun 20, 2022
Cleanup will be skipped and test will exit bypassing cleanup if a different context goroutine panics or asserts without deferring the ginkgo recover function. Related to openservicemesh#3119 Signed-off-by: jaellio <[email protected]>
trstringer
pushed a commit
that referenced
this pull request
Jun 21, 2022
* tests: add ginko panic recovery to retry policy e2e Cleanup will be skipped and test will exit bypassing cleanup if a different context goroutine panics or asserts without deferring the ginkgo recover function. Related to #3119 Signed-off-by: jaellio <[email protected]> * add more ginkgoRecovers Signed-off-by: jaellio <[email protected]> * remove ginkgoRecover from wait.Poll Signed-off-by: jaellio <[email protected]> * Upgrade yaml to v3.0.1 Signed-off-by: jaellio <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup will be skipped and test will exit bypassing cleanup
if a different context goroutine panics or asserts without
deferring the ginkgo recover function.
This causes logs to not be collected in some situations (ie,
when a test has some goroutines waiting for NS to come up
but they don't).
Signed-off-by: edu [email protected]
Tests [x]
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No