This repository was archived by the owner on Jul 11, 2023. It is now read-only.
(k8s/informers): Use InformerCollection for other clients #4804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new InformerCollection instead of fragmenting informers across different clients Signed-off-by: Keith Mattix II <[email protected]>
keithmattix
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio and
trstringer
as code owners
steeling
approved these changes
Jun 9, 2022
Signed-off-by: Keith Mattix II <[email protected]>
keithmattix
commented
Jun 10, 2022
Signed-off-by: Keith Mattix II <[email protected]>
keithmattix
force-pushed
the
refactor/use-informer-collection-for-other-clients
branch
from
a34bdb6 to
333700a
Compare
…r config becaues it's going away Signed-off-by: Keith Mattix II <[email protected]>
Signed-off-by: Keith Mattix II <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4804 +/- ##
==========================================
- Coverage 68.54% 68.51% -0.04%
==========================================
Files 223 223
Lines 16225 16075 -150
==========================================
- Hits 11122 11013 -109
+ Misses 5052 5011 -41
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Keith Mattix II <[email protected]>
nojnhuh
approved these changes
Jun 13, 2022
Signed-off-by: Keith Mattix II <[email protected]>
jaellio
approved these changes
Jun 13, 2022
steeling
approved these changes
Jun 13, 2022
keithmattix
deleted the
refactor/use-informer-collection-for-other-clients
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new InformerCollection instead of fragmenting informers across
different clients
Part of #4551
Signed-off-by: Keith Mattix II [email protected]
Description:
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?