Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Commit b825c53

Browse files
committed
Fix typos
Signed-off-by: Keith Mattix II <[email protected]>
1 parent 283e938 commit b825c53

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

cmd/osm-controller/osm-controller.go

-3
Original file line numberDiff line numberDiff line change
@@ -245,9 +245,6 @@ func main() {
245245
}
246246

247247
policyController := policy.NewPolicyController(informerCollection, k8sClient, msgBroker)
248-
if err != nil {
249-
events.GenericEventRecorder().FatalEvent(err, events.InitializationError, "Error creating controller for policy.openservicemesh.io")
250-
}
251248

252249
meshCatalog := catalog.NewMeshCatalog(
253250
k8sClient,

pkg/k8s/informers/informers.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ func (ic *InformerCollection) run(stop <-chan struct{}) error {
138138

139139
// Add is only exported for the sake of tests and requires a testing.T to ensure it's
140140
// never used in production. This functionality was added for the express purpose of testing
141-
// flexibility since alternatives can often leads to flaky tests and race conditions
141+
// flexibility since alternatives can often lead to flaky tests and race conditions
142142
// between the time an object is added to a fake clientset and when that object
143143
// is actually added to the informer `cache.Store`
144144
func (ic *InformerCollection) Add(key InformerKey, obj interface{}, t *testing.T) error {
@@ -156,7 +156,7 @@ func (ic *InformerCollection) Add(key InformerKey, obj interface{}, t *testing.T
156156

157157
// Update is only exported for the sake of tests and requires a testing.T to ensure it's
158158
// never used in production. This functionality was added for the express purpose of testing
159-
// flexibility since the alternatives can often leads to flaky tests and race conditions
159+
// flexibility since the alternatives can often lead to flaky tests and race conditions
160160
// between the time an object is added to a fake clientset and when that object
161161
// is actually added to the informer `cache.Store`
162162
func (ic *InformerCollection) Update(key InformerKey, obj interface{}, t *testing.T) error {

pkg/validator/validators_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -1362,7 +1362,7 @@ func TestUpstreamTrafficSettingValidator(t *testing.T) {
13621362
policyClient: policyClient,
13631363
}
13641364

1365-
// Block until we start getting ingressbackend updates
1365+
// Block until we start getting upstreamtrafficsetting updates
13661366
// We only do this because the informerCollection doesn't have the
13671367
// policy client's msgBroker eventhandler registered when it initially runs
13681368
// and that leads to a race condition in tests (due to the kubeController mockss)

0 commit comments

Comments
 (0)