This repository was archived by the owner on Jul 11, 2023. It is now read-only.
chore: remove osm-controller cert issuance metrics #4113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes metrics store initialization of certificate issuance metrics for the osm-controller. Cert issuance metrics are currently initialized by osm-controller but never updated. Thus, the cert issuance metrics are always zero. Certificate issuance metrics are instead maintained by osm-injector. Signed-off-by: Johnson Shi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4113 +/- ##
==========================================
+ Coverage 69.12% 69.18% +0.05%
==========================================
Files 205 205
Lines 11240 11238 -2
==========================================
+ Hits 7770 7775 +5
+ Misses 3418 3411 -7
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jaellio
approved these changes
Sep 15, 2021
michelleN
approved these changes
Sep 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes metrics store initialization of certificate
issuance metrics for the osm-controller. Cert issuance
metrics are currently initialized by osm-controller but
never updated. Thus, the cert issuance metrics are always
zero.
Certificate issuance metrics are instead maintained by
osm-injector.
Signed-off-by: Johnson Shi [email protected]
Description:
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? No
Is this a breaking change? No