chore: remove osm-controller cert issuance metrics (#4113)

johnsonshi · web-flow · commit 963cf8f0bd1b · 2021-09-16T14:40:47.000-07:00
Removes metrics store initialization of certificate
issuance metrics for the osm-controller. Cert issuance
metrics are currently initialized by osm-controller but
never updated. Thus, the cert issuance metrics are always
zero.

Certificate issuance metrics are instead maintained by
osm-injector.

Signed-off-by: Johnson Shi &lt;Johnson.Shi@microsoft.com&gt;
diff --git a/cmd/osm-controller/osm-controller.go b/cmd/osm-controller/osm-controller.go
@@ -294,8 +294,6 @@ func startMetricsStore() {
 		metricsstore.DefaultMetricsStore.ProxyReconnectCount,
 		metricsstore.DefaultMetricsStore.ProxyConfigUpdateTime,
 		metricsstore.DefaultMetricsStore.ProxyBroadcastEventCount,
-		metricsstore.DefaultMetricsStore.CertIssuedCount,
-		metricsstore.DefaultMetricsStore.CertIssuedTime,
 		metricsstore.DefaultMetricsStore.ErrCodeCounter,
 	)
 }

Original file line number	Diff line number	Diff line change
`@@ -294,8 +294,6 @@ func startMetricsStore() {`
`294`	`294`	`metricsstore.DefaultMetricsStore.ProxyReconnectCount,`
`295`	`295`	`metricsstore.DefaultMetricsStore.ProxyConfigUpdateTime,`
`296`	`296`	`metricsstore.DefaultMetricsStore.ProxyBroadcastEventCount,`
`297`		`- metricsstore.DefaultMetricsStore.CertIssuedCount,`
`298`		`- metricsstore.DefaultMetricsStore.CertIssuedTime,`
`299`	`297`	`metricsstore.DefaultMetricsStore.ErrCodeCounter,`
`300`	`298`	`)`
`301`	`299`	`}`