Skip to content

Fix Integration test #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 18, 2025
Merged

Fix Integration test #1764

merged 8 commits into from
Apr 18, 2025

Conversation

yyfamazon
Copy link
Contributor

@yyfamazon yyfamazon commented Apr 15, 2025

Description

Fix dashboard-assistant test
Deprecate CatIndexTool and use ListIndexTool

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: yyfamazon <[email protected]>
@peterzhuamazon
Copy link
Member

Hi @SuZhou-Joe @wanglam @ruanyl can we go ahead and merge this?

Thanks.

@wanglam
Copy link
Collaborator

wanglam commented Apr 16, 2025

Hi @SuZhou-Joe @wanglam @ruanyl can we go ahead and merge this?

Thanks.

Hi @peterzhuamazon, the integration tests still failed due to test cases based on 3.0.0-beta1. The current integration tests are still using 3.0.0-alpha1 OSD and OS. @SuZhou-Joe will update the version in package.json and we will check if these integration tests can be passed.

@peterzhuamazon
Copy link
Member

Hi @wanglam @yyfamazon seems like still failure on this?

Thanks.

@peterzhuamazon
Copy link
Member

Still seeing failures.

Signed-off-by: yyfamazon <[email protected]>
Signed-off-by: yyfamazon <[email protected]>
@wanglam
Copy link
Collaborator

wanglam commented Apr 18, 2025

Still seeing failures.

Hi @peterzhuamazon, there are two main issues in the dashboards assistants integration tests:

  1. "Save to notebook" failed due to the observability-dashboards plugin removing the create notebook API in Remove support for legacy notebooks dashboards-observability#2406
  2. "Test without security" only fails in GitHub Actions. The ML Commons OpenSearch throws a NullPointerException. It passes in our local or Ubuntu Linux 24 environments. "Test with security" succeeds in GitHub Actions. Still seeking the root cause.

I think it's safe to merge this PR, since the current integration tests are failing too. The MDS check and test with security should pass (except for "Save to notebook" case) after this PR is merged.

Signed-off-by: yyfamazon <[email protected]>
@peterzhuamazon
Copy link
Member

Sure @wanglam I will leave you to merge it.

Thanks.

@wanglam
Copy link
Collaborator

wanglam commented Apr 18, 2025

@yyfamazon Could you add these changes in this commit(c0a6a69) to this PR? I've tested in my another PR, the "test without security" except for "Save to notebooks" can be passed in this workflow.

@wanglam wanglam merged commit e2af805 into opensearch-project:main Apr 18, 2025
66 of 68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 18, 2025
* Fix Integration test

Signed-off-by: yyfamazon <[email protected]>

* delete wait 12 seconds

Signed-off-by: yyfamazon <[email protected]>

* delte wait 2 minutes

Signed-off-by: yyfamazon <[email protected]>

* add wait time

Signed-off-by: yyfamazon <[email protected]>

* Fix assitant failed due to join cluster

Signed-off-by: yyfamazon <[email protected]>

---------

Signed-off-by: yyfamazon <[email protected]>
(cherry picked from commit e2af805)
peterzhuamazon pushed a commit that referenced this pull request Apr 29, 2025
* Fix Integration test



* delete wait 12 seconds



* delte wait 2 minutes



* add wait time



* Fix assitant failed due to join cluster



---------


(cherry picked from commit e2af805)

Signed-off-by: yyfamazon <[email protected]>
Co-authored-by: yyfamazon <[email protected]>
Co-authored-by: Lin Wang <[email protected]>
@SuZhou-Joe SuZhou-Joe added the v3.0.0 v3.0.0 label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants