-
Notifications
You must be signed in to change notification settings - Fork 123
Fix Integration test #1764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Integration test #1764
Conversation
Signed-off-by: yyfamazon <[email protected]>
Hi @SuZhou-Joe @wanglam @ruanyl can we go ahead and merge this? Thanks. |
Hi @peterzhuamazon, the integration tests still failed due to test cases based on |
Hi @wanglam @yyfamazon seems like still failure on this? Thanks. |
Still seeing failures. |
cypress/integration/plugins/dashboards-assistant/mds_chatbot_agent_framework_spec.js
Outdated
Show resolved
Hide resolved
Signed-off-by: yyfamazon <[email protected]>
Signed-off-by: yyfamazon <[email protected]>
Hi @peterzhuamazon, there are two main issues in the dashboards assistants integration tests:
I think it's safe to merge this PR, since the current integration tests are failing too. The MDS check and test with security should pass (except for "Save to notebook" case) after this PR is merged. |
Signed-off-by: yyfamazon <[email protected]>
Sure @wanglam I will leave you to merge it. Thanks. |
@yyfamazon Could you add these changes in this commit(c0a6a69) to this PR? I've tested in my another PR, the "test without security" except for "Save to notebooks" can be passed in this workflow. |
Signed-off-by: yyfamazon <[email protected]>
* Fix Integration test Signed-off-by: yyfamazon <[email protected]> * delete wait 12 seconds Signed-off-by: yyfamazon <[email protected]> * delte wait 2 minutes Signed-off-by: yyfamazon <[email protected]> * add wait time Signed-off-by: yyfamazon <[email protected]> * Fix assitant failed due to join cluster Signed-off-by: yyfamazon <[email protected]> --------- Signed-off-by: yyfamazon <[email protected]> (cherry picked from commit e2af805)
* Fix Integration test * delete wait 12 seconds * delte wait 2 minutes * add wait time * Fix assitant failed due to join cluster --------- (cherry picked from commit e2af805) Signed-off-by: yyfamazon <[email protected]> Co-authored-by: yyfamazon <[email protected]> Co-authored-by: Lin Wang <[email protected]>
Description
Fix dashboard-assistant test
Deprecate CatIndexTool and use ListIndexTool
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.