Remove support for legacy notebooks #2406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
joshuali925
approved these changes
Apr 8, 2025
| // ${NOTEBOOKS_API_PREFIX}/: this point to old notebooks saved in observability index | ||
| return Promise.all([ | ||
| this.props.http.get(`${NOTEBOOKS_API_PREFIX}/savedNotebook`), | ||
| this.props.http.get(`${NOTEBOOKS_API_PREFIX}/`), |
There was a problem hiding this comment.
should this route also be removed?
There was a problem hiding this comment.
yes, removed all legacy ones here: 7a7adae
TackAdam
approved these changes
Apr 8, 2025
Signed-off-by: Shenoy Pratik <[email protected]>
paulstn
approved these changes
Apr 8, 2025
mengweieric
pushed a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Apr 8, 2025
* remove support for legacy notebooks Signed-off-by: Shenoy Pratik <[email protected]> * remove legacy endpoints and adaptors Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]>
mengweieric
added a commit
that referenced
this pull request
Apr 8, 2025
* updated release notes (#1997) Signed-off-by: sumukhswamy <[email protected]> * Remove support for legacy notebooks (#2406) * remove support for legacy notebooks Signed-off-by: Shenoy Pratik <[email protected]> * remove legacy endpoints and adaptors Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> * updated release notes (#1997) Signed-off-by: sumukhswamy <[email protected]> * release notes Signed-off-by: Eric <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Eric <[email protected]> Co-authored-by: Sumukh Swamy <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> Co-authored-by: Adam Tackett <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove support for legacy notebooks. Notebooks plugin only supports savedNotebooks stored in
.kibana. The support for notebooks in.opensearch-observabilityis removed in OSD 3.0.0 versionIssues Resolved
#2350
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.