[RPM M1] Tweak OpenSearch build.sh so the rpm artifact is having saming naming convention #1657
Conversation
… convention Signed-off-by: Peter Zhu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main opensearch-project/opensearch-build#1657 +/- ##
=========================================
Coverage 94.69% 94.69%
Complexity 14 14
=========================================
Files 163 163
Lines 3447 3447
Branches 21 21
=========================================
Hits 3264 3264
Misses 180 180
Partials 3 3 Continue to review full report at Codecov.
|
peterzhuamazon
changed the title
| ARTIFACT_TARGET_BUILD_NAME=opensearch-min-$VERSION$IDENTIFIER-$QUALIFIER.$EXT | ||
| [ ! -z "$QUALIFIER_ALT" ] && ARTIFACT_TARGET_BUILD_NAME=opensearch-min-$VERSION$IDENTIFIER-$QUALIFIER_ALT.$EXT |
There was a problem hiding this comment.
For the right naming convention a change should be made in OpenSearch rather than renaming the artifact here. It can be confusing if someone tries to build OpenSearch rpm using core repo.
I think this issue was created for the same purpose: https://github.com/opensearch-project/opensearch-build/issues/397
There was a problem hiding this comment.
Not knowing this issue exist to start with.
The reason I havent change core is due to yum probably need us to keep x86_64 naming.
Will keep this PR open for a while.
There was a problem hiding this comment.
We have the naming as a requirements here, the reason I rename it is to keep consistency:
#1548
|
Close this now. |
Signed-off-by: Peter Zhu [email protected]
Description
Tweak OpenSearch build.sh so the rpm artifact is having saming naming convention
Issues Resolved
Part of #1655
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.