Skip to content

[META][Enhancement] Passing value of --distribution to build scripts of all components #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peterzhuamazon opened this issue Feb 18, 2022 · 1 comment
Assignees
Labels

Comments

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Feb 18, 2022

As of now only OpenSearch core component support passing ./build.sh --distribution <> value to its build.sh as -d <>.

I will update OpenSearch-Dashboards build.sh once they support arm64 os packages:
opensearch-project/OpenSearch-Dashboards#1259

As of now, we use a hack to make sure only core components will take -d while skip others:
#1651

We should add -d support for all the build.sh scripts for all the components.
Due to the nature of different components, their code are not always the same to support this.
And the build.sh of different components are residing in different repos.
Some use the default one on build repo, some use the custom one on build repo components folder, some use the custom one on their own repo.

All components on manifests/<>/opensearch-<>.yml and manifests/<>/opensearch-dashboards-<>.yml should be updated as well as all existing default ones in scripts/.

Thanks.


OpenSearch:

OpenSearch-Dashboards:

@peterzhuamazon peterzhuamazon changed the title [Enhancement] Passing value of --distribution to build scripts of all components [META][Enhancement] Passing value of --distribution to build scripts of all components Feb 18, 2022
@peterzhuamazon peterzhuamazon self-assigned this Feb 18, 2022
@peterzhuamazon
Copy link
Member Author

Since plugin installation only use zips regardless of distribution, and we already support the core / min to have distribution option, this issue can be closed for now.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant