Skip to content

[RPM M1] Update dashboards build script to consume distribution #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu [email protected]

Description

Update dashboards build script to consume distribution

Issues Resolved

Part of #1655

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon self-assigned this Feb 18, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner February 18, 2022 22:12
@peterzhuamazon
Copy link
Member Author

Note: This does not include rpm arm64 because dashboards currently cannot build that for core.
opensearch-project/OpenSearch-Dashboards#1259

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #1656 (d95a1e6) into main (18c173c) will not change coverage.
The diff coverage is n/a.

❗ Current head d95a1e6 differs from pull request most recent head 5477151. Consider uploading reports for the commit 5477151 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1656   +/-   ##
=========================================
  Coverage     94.68%   94.68%           
  Complexity       14       14           
=========================================
  Files           163      163           
  Lines          3446     3446           
  Branches         21       21           
=========================================
  Hits           3263     3263           
  Misses          180      180           
  Partials          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c173c...5477151. Read the comment docs.

@peterzhuamazon peterzhuamazon force-pushed the opensearch-dashboards-buildsh branch from d95a1e6 to 5477151 Compare February 18, 2022 23:04
@peterzhuamazon
Copy link
Member Author

@dblock please take a look when you have time.
Thanks.

@peterzhuamazon peterzhuamazon merged commit 504427b into opensearch-project:main Feb 19, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-dashboards-buildsh branch February 19, 2022 00:34
@peterzhuamazon peterzhuamazon changed the title Update dashboards build script to consume distribution [RPM M1] Update dashboards build script to consume distribution Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants