Add sha512 generation to promotion job #1367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The promotion workflow is picking up artifacts from a distribution build and placing them in their final resting place on the artifacts server. This is a perfect oppertunity to do any final polishing steps on artifacts that are ready for release. Adding this hook for file actions and creating a sha512 generation closure. This is untested on jenkins, but is the core POC needed to bootstrap the signing workflow. Signed-off-by: Peter Nied <[email protected]>
peternied
commented
Dec 17, 2021
Codecov Report
@@ Coverage Diff @@
## main #1367 +/- ##
=========================================
Coverage 94.02% 94.02%
Complexity 11 11
=========================================
Files 136 138 +2
Lines 3011 3013 +2
Branches 8 8
=========================================
+ Hits 2831 2833 +2
Misses 172 172
Partials 8 8
Continue to review full report at Codecov.
|
peterzhuamazon
approved these changes
Dec 17, 2021
dblock
approved these changes
Dec 17, 2021
Minor fixes during testing Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
dblock
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The promotion workflow is picking up artifacts from a distribution build and placing them in their final resting place on the artifacts server. This is a perfect opportunity to do any final polishing steps on artifacts that are ready for release. Adding this hook for file actions and creating a sha512 generation closure.
This is untested on jenkins, but is the core POC needed to bootstrap the signing workflow.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.