Skip to content

[Enhancement] Add tests and improvement to the promotion jenkins workflow #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peterzhuamazon opened this issue Dec 16, 2021 · 1 comment
Labels
enhancement New Enhancement

Comments

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Dec 16, 2021

We are adding tar and native plugin zips auto promotion here: #1354

There are several improvement needed after the PR is merged:

  1. Write a full test for the jenkinsfile, including gradle/groovy test case file, sample jenkinsfile, txt results.
  2. Put s3upload params to its own variable.
  3. Rename all the AWS_ACCOUNT_PUBLIC to AWS_CENTRAL_ARTIFACT_ACCOUNT as it is mistakenly added 1st in Jenkins with a wrong name, and rename all the entries related to it.
  4. As of now it is designed to trigger multiple times by engineer on different arch/platform, we can definitely add a multi-arch trigger so we dont need to manually trigger it multiple times.
  5. Reduce the number of params needed for the jenkinfile.
  6. Use build parameter more as that feeds in more information for the task.
@gaiksaya
Copy link
Member

Closing this as the feature has been implemented via #4280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants