[BUG] Getting DeadlineTimeoutException error during security tests after upgrading to 3.0 #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qreshi investigating the possible failures of the test cases (I cannot reproduce them locally yet), would appreciate your assistance in approving workflows, thank you |
reta
force-pushed
the
issue-580
branch
20 times, most recently
from
d8e3f40 to
d45519e
Compare
…ter upgrading to 3.0 Signed-off-by: Andriy Redko <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #583 +/- ##
=========================================
Coverage 61.36% 61.36%
Complexity 112 112
=========================================
Files 73 73
Lines 2472 2472
Branches 265 265
=========================================
Hits 1517 1517
Misses 778 778
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The test failures seems to be "known" and not related to this pull request |
qreshi
approved these changes
Jan 5, 2023
lezzago
approved these changes
Jan 5, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko [email protected]
Description
Getting DeadlineTimeoutException error during security tests after upgrading to 3.0. The test failures were caused by incorrect defaults
SecureRestClientBuilderrelated toconnectionRequestTimeout: the value was set t o0which basically meant for strict connection pool to fail immediately if the connection is not available.Issues Resolved
Closes #580
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.