Version bump to 3.0 #762
Merged
Version bump to 3.0 #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
|
The failing security tests are due to Notification not available in the latest 3.0 build. Additionally the BWC failures are known existing failures with OS 3.0 |
AWSHurneyt
approved these changes
Jan 19, 2023
Angie-Zhang
approved these changes
Jan 23, 2023
| userClient = SecureRestClientBuilder(clusterHosts.toTypedArray(), isHttps(), user, user).setSocketTimeout(60000).build() | ||
| userClient = SecureRestClientBuilder(clusterHosts.toTypedArray(), isHttps(), user, user) | ||
| .setSocketTimeout(60000) | ||
| .setConnectionRequestTimeout(180000) |
There was a problem hiding this comment.
What is the reason of this request timeout?
There was a problem hiding this comment.
This is the related PR to prevent DeadlineTimeoutException
Comment on lines
+116
to
+151
| /** | ||
| * Executes the given [block] function on this resource and then closes it down correctly whether an exception | ||
| * is thrown or not. | ||
| * | ||
| * In case if the resource is being closed due to an exception occurred in [block], and the closing also fails with an exception, | ||
| * the latter is added to the [suppressed][java.lang.Throwable.addSuppressed] exceptions of the former. | ||
| * | ||
| * @param block a function to process this [AutoCloseable] resource. | ||
| * @return the result of [block] function invoked on this resource. | ||
| */ | ||
| inline fun <T : ThreadContext.StoredContext, R> T.use(block: (T) -> R): R { | ||
| var exception: Throwable? = null | ||
| try { | ||
| return block(this) | ||
| } catch (e: Throwable) { | ||
| exception = e | ||
| throw e | ||
| } finally { | ||
| closeFinally(exception) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Closes this [AutoCloseable], suppressing possible exception or error thrown by [AutoCloseable.close] function when | ||
| * it's being closed due to some other [cause] exception occurred. | ||
| * | ||
| * The suppressed exception is added to the list of suppressed exceptions of [cause] exception. | ||
| */ | ||
| fun ThreadContext.StoredContext.closeFinally(cause: Throwable?) = when (cause) { | ||
| null -> close() | ||
| else -> try { | ||
| close() | ||
| } catch (closeException: Throwable) { | ||
| cause.addSuppressed(closeException) | ||
| } | ||
| } |
There was a problem hiding this comment.
Why adding these logic here? Is this needed for all the plugins after 3.0?
There was a problem hiding this comment.
Yes, we need this after 3.0 since these functions are no longer available. We can do a followup PR to maybe move this to common-utils.
bowenlan-amzn
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#493
Description of changes:
Update Alerting main branch to version OpenSearch 3.0
CheckList:
[X] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.