Skip to content

Add -Dbuild.snapshot=$SNAPSHOT in build script for libs #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Add -Dbuild.snapshot=$SNAPSHOT in build script for libs #2757

merged 1 commit into from
Jun 16, 2025

Conversation

jmazanec15
Copy link
Member

@jmazanec15 jmazanec15 commented Jun 16, 2025 •
edited
Loading

Description

Add build.snapshot to build script to fix lib build issue.

SNAPSHOT=true
./gradlew :buildJniLib -Pknn_libs=opensearchknn_nmslib -Dbuild.lib.commit_patches=false -Dbuild.lib.apply_patches=false -Dbuild.snapshot=$SNAPSHOT
...
CMake command: cmake -S jni -B jni/build -DKNN_PLUGIN_VERSION=3.1.0-SNAPSHOT -DCOMMIT_LIB_PATCHES=false -DAPPLY_LIB_PATCHES=false -DCMAKE_POLICY_VERSION_MINIMUM=3.5
...
BUILD SUCCESSFUL in 6s

Related Issues

Resolves #2569

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jmazanec15 jmazanec15 added the Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Jun 16, 2025
@jmazanec15 jmazanec15 merged commit 7634987 into opensearch-project:main Jun 16, 2025
23 checks passed
luyuncheng pushed a commit to luyuncheng/k-NN-1 that referenced this pull request Jun 18, 2025
@jmazanec15 @luyuncheng
Add -Dbuild.snapshot=$SNAPSHOT in build script for libs (opensearch-p…
039f385 
…roject#2757)

Signed-off-by: John Mazanec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveentatikonda naveentatikonda naveentatikonda approved these changes

@shatejas shatejas shatejas approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan ryanbogan is a code owner

@luyuncheng luyuncheng Awaiting requested review from luyuncheng luyuncheng is a code owner

@0ctopus13prime 0ctopus13prime Awaiting requested review from 0ctopus13prime 0ctopus13prime is a code owner

@Vikasht34 Vikasht34 Awaiting requested review from Vikasht34 Vikasht34 is a code owner

Assignees
No one assigned
Labels
Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Knn plugin is fetching from snapshot for few dependencies
3 participants
@jmazanec15 @naveentatikonda @shatejas