[BUG] Knn plugin is fetching from snapshot for few dependencies

[owaiskazi19]

What is the bug?
For building jniLIb, knn is fetching from snapshot rather release version here

How can one reproduce the bug?
Steps to reproduce the behavior:

1. Build the release version of knn from any release branch like 2.18 or 2.19
2. See for the build ./gradlew :buildJniLib -Davx512.enabled=false -Davx2.enabled=false -Dbuild.lib.commit_patches=false, it fetches the snapshot version

What is the expected behavior?
Should fetch from the release version

What is your host/environment?

• OS: [e.g. iOS]
• Version [e.g. 22]
• Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
Add any other context about the problem.

[gaiksaya]

Adding more context,

Recently 2.18.0-SNAPSHOTS were unavailable on https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/gradle/build-tools/ due to some issue with sonatype storage.
On trying to build, 2.18.0 distribution using manifest file , k-NN failed with below error:

* What went wrong:
A problem occurred configuring root project 'opensearch-knn'.
> Could not resolve all files for configuration ':classpath'.
   > Could not find org.opensearch.gradle:build-tools:2.18.0-SNAPSHOT.
     Searched in the following locations:
       - file:/home/ci-runner/.m2/repository/org/opensearch/gradle/build-tools/2.18.0-SNAPSHOT/maven-metadata.xml
       - file:/home/ci-runner/.m2/repository/org/opensearch/gradle/build-tools/2.18.0-SNAPSHOT/build-tools-2.18.0-SNAPSHOT.pom
       - https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/gradle/build-tools/2.18.0-SNAPSHOT/maven-metadata.xml
       - https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/gradle/build-tools/2.18.0-SNAPSHOT/build-tools-2.18.0-SNAPSHOT.pom
       - https://repo.maven.apache.org/maven2/org/opensearch/gradle/build-tools/2.18.0-SNAPSHOT/maven-metadata.xml
       - https://repo.maven.apache.org/maven2/org/opensearch/gradle/build-tools/2.18.0-SNAPSHOT/build-tools-2.18.0-SNAPSHOT.pom
       - https://plugins.gradle.org/m2/org/opensearch/gradle/build-tools/2.18.0-SNAPSHOT/maven-metadata.xml
       - https://plugins.gradle.org/m2/org/opensearch/gradle/build-tools/2.18.0-SNAPSHOT/build-tools-2.18.0-SNAPSHOT.pom
     Required by:
         project 

This is coming from https://github.com/opensearch-project/k-NN/blob/2.18.0.0/scripts/build.sh#L127-L134
Looks like gradle tries to compile the dependencies and since gradle property of "opensearch.version" is not passed in while building JNI library here, it takes the default which was set to 2.18.0-SNAPSHOT.
cc: @navneet1v @jmazanec15 @peterzhuamazon

[peterzhuamazon]

Hi @owaiskazi19 @gaiksaya as per offline discussion yes we are in the process of contacting sonatype on this.

Thanks.

[owaiskazi19]

Hi @owaiskazi19 @gaiksaya as per offline discussion yes we are in the process of contacting sonatype on this.

@peterzhuamazon that's not the issue here. Issue is with the knn build file using SNAPSHOT version rather release version for building jni library.

[navneet1v]

Hi @owaiskazi19 @gaiksaya as per offline discussion yes we are in the process of contacting sonatype on this.

@peterzhuamazon that's not the issue here. Issue is with the knn build file using SNAPSHOT version rather release version for building jni library.

@owaiskazi19 I think its not JNI lib, its the build script we have in the k-NN repo. Correct? JNI as per my understanding don't look at SNAPSHOT version or not.

[peterzhuamazon]

Hi @owaiskazi19 @gaiksaya as per offline discussion yes we are in the process of contacting sonatype on this.

@peterzhuamazon that's not the issue here. Issue is with the knn build file using SNAPSHOT version rather release version for building jni library.

@owaiskazi19 I think its not JNI lib, its the build script we have in the k-NN repo. Correct? JNI as per my understanding don't look at SNAPSHOT version or not.

If concerned, add -Dbuild.snapshot=$SNAPSHOT in scripts/build.sh on the corresponding lines should be fine.

If you run the command by itself it will just default to snapshot=true.

[owaiskazi19]

@owaiskazi19 I think its not JNI lib, its the build script we have in the k-NN repo. Correct? JNI as per my understanding don't look at SNAPSHOT version or not.

Yes it's the build script

[jmazanec15]

This should be pretty easy to fix. @gaiksaya is this still an issue?

[gaiksaya]

Yes! It was caught because of maven snapshot issues but technically the gradle commands needs to be fixed to use exactly what it provided at the top level than using using default values.