-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: BiGGer: A Model Transformation Tool written in Java for Bigraph Rewriting in GrGen.NET #6491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
|
Review checklist for @idobyConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @abhishektiwariConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hello reviewers @abhishektiwari, @Ethan-CS, @idoby |
Hello @abhishektiwari, @Ethan-CS, @idoby kind reminder to provide some feedback on your review progress. |
@vissarion Thanks for the nudge. I will aim to provide first feedback mid next week. |
Thanks for the reminder - really sorry about the delay, I’ve been out of action due to illness for a while but getting back to it now I’m out of hospital. Will keep in touch, aiming to have finished by end of next week.
On 14 May 2024, at 11:29, Vissarion Fisikopoulos ***@***.***> wrote:
Hello @abhishektiwari<https://github.com/abhishektiwari>, @Ethan-CS<https://github.com/Ethan-CS>, @idoby<https://github.com/idoby> kind reminder to provide some feedback on your review progress.
—
Reply to this email directly, view it on GitHub<#6491 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARIYWRTWQSJBBLGVUH6QGJTZCHRPTAVCNFSM6AAAAABEXU36XGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZHA2DGMRZGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi, thanks for the reminder! While this is well outside my field of expertise, just looking at the code it seems that this is a rather thin tool built on top of the GrGen framework. Can the author please explain why this package represents the results of significant scholarly effort as JOSS requires? It seems to me that if this code was written as part of a research paper on bigraphs, it might belong there rather than be published as a stand-alone general-use tool or library. I would appreciate it if the author could clarify these points. |
Sure, I will be glad to clarify the purpose of this tool! Note that the present tool paper is part of another journal paper entitled "Efficient Bigraph Rewriting using GrGen.NET" submitted for review to ACM Formal Aspects of Computing, where the full mathematical details are given on how the method actually works that is implemented as presented here for JOSS. In the software engineering communities it is widely acknowledged that graphs are a appropriate underlying mathematical formalism for representing and analyzing software models, modeling languages, processes and systems. However, graph transformation essentially refers to the subgraph isomorphism problem, and more specifically for bigraphs this is referred to finding the forest in a tree (see [BaMR14]), both are NP-complete. That being said, implementing bigraph matching and rewriting using the transformation tool GrGen.NET is for the following reasons. I hope this clarifies some of your points. Should you have any further questions, I am more than happy to assist. Kind regards, [EEPT06] Ehrig, Hartmut; Ehrig, Karsten; Prange, Ulrike; Taentzer, Gabriele: Fundamentals of Algebraic Graph Transformation, Monographs in Theoretical Computer Science. An EATCS Series. Berlin Heidelberg : Springer-Verlag, 2006 — ISBN 978-3-540-31187-4 |
Your explanation does sound to me like substantial contribution has been made to your field in the other paper, and hope that it gets accepted into the ACM journal. To conclude, while I applaud the scientific effort in developing the math, algorithms and implementation behind this package, I still have concerns regarding its fit for JOSS. Since the JOSS guidelines are somewhat vague on this topic ("Co-publication of science, methods, and software"), I believe the decision should lie with the editor @vissarion. |
@editorialbot query scope |
Submission flagged for editorial review. |
@idoby @PioBeat I have some news regarding the query scope. I am convinced (and other JOSS editors agree) that in this case the method and the software can be considered are separate contributions. The software seems to address specific software challenges, it contains useful sample data for testing and evaluation and comes with detailed instructions. Thus, I will remove the query-scope tag and we could continue the review process. @idoby is this OK with you? |
Sure, I will continue my review then. |
Done @vissarion |
@editorialbot set 10.5281/zenodo.11565998 as archive |
Done! archive is now 10.5281/zenodo.11565998 |
@editorialbot set v1.2.0 as version |
Done! version is now v1.2.0 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5482, then you can now move forward with accepting the submission by compiling again with the command |
@PioBeat - As track editor, I've now proofread your paper. I've suggested a lot of changes in bigraph-toolkit-suite/bigraphs.grgen-bigraphs#5. Please merge this or let me know what you disagree with, then we can generate another proof as a final check and then publish the work. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5487, then you can now move forward with accepting the submission by compiling again with the command |
@PioBeat - please take a look at this proof and confirm it looks ok. I will also look at it. |
Dear @danielskatz Thank you very much for the editing. I have pushed also a small typo fix. |
Thanks for catching that. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @PioBeat (Dominik Grzelak) on your publication!! And thanks to @abhishektiwari and @idoby for reviewing, and to @vissarion for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @PioBeat (Dominik Grzelak)
Repository: https://github.com/bigraph-toolkit-suite/bigraphs.grgen-bigraphs
Branch with paper.md (empty if default branch):
Version: v1.2.0
Editor: @vissarion
Reviewers: @abhishektiwari, @idoby
Archive: 10.5281/zenodo.11565998
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@abhishektiwari & @Ethan-CS & @idoby, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @vissarion know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @idoby
📝 Checklist for @abhishektiwari
The text was updated successfully, but these errors were encountered: