Skip to content

[PRE REVIEW]: BiGGer: A Model Transformation Tool written in Java for Bigraph Rewriting in GrGen.NET #6342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
editorialbot opened this issue Feb 9, 2024 · 54 comments
Assignees
Labels
Java pre-review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 9, 2024

Submitting author: @PioBeat (Dominik Grzelak)
Repository: https://github.com/bigraph-toolkit-suite/bigraphs.grgen-bigraphs
Branch with paper.md (empty if default branch):
Version: v1.0
Editor: @vissarion
Reviewers: @abhishektiwari, @Ethan-CS, @idoby
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a4588689144a60762ef9a6df20096b2c"><img src="https://joss.theoj.org/papers/a4588689144a60762ef9a6df20096b2c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a4588689144a60762ef9a6df20096b2c/status.svg)](https://joss.theoj.org/papers/a4588689144a60762ef9a6df20096b2c)

Author instructions

Thanks for submitting your paper to JOSS @PioBeat. Currently, there isn't a JOSS editor assigned to your paper.

@PioBeat if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Feb 9, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.06 s (771.3 files/s, 76903.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Java                            25            385            431           2045
Markdown                         2            177              0            489
TeX                              1             14              0            331
Maven                            1             10             17            294
XMI                             12              0              0            287
XML                              4              0              0            274
YAML                             1              1              4             18
JSON                             2              0              0              9
-------------------------------------------------------------------------------
SUM:                            48            587            452           3747
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1992

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-030-43916-3 is OK
- 10.1007/978-3-319-75396-6_5 is OK
- 10.1007/978-3-540-31847-7_20 is OK
- 10.1142/9789812562494_0038 is OK
- 10.1007/3-540-31188-2 is OK
- 10.1007/978-3-030-51372-6_3 is OK
- 10.1016/j.dam.2018.07.006 is OK
- 10.1109/VLHCC.2005.23 is OK
- 10.5445/IR/1000007369 is OK
- 10.4204/EPTCS.231.2 is OK
- 10.1016/j.entcs.2007.04.013 is OK
- 10.1007/s00165-011-0184-5 is OK
- 10.1007/978-3-319-41540-6_27 is OK
- 10.1007/978-3-540-89020-1_38 is OK

MISSING DOIs

- 10.1007/3-540-44618-4_19 may be a valid DOI for title: Deriving Bisimulation Congruences for Reactive Systems
- 10.1007/11841883_27 may be a valid DOI for title: GrGen: A Fast SPO-Based Graph Rewriting Tool
- 10.1007/978-3-642-03741-2_28 may be a valid DOI for title: DBtk: A Toolkit for Directed Bigraphs

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

GBOML: Graph-Based Optimization Modeling Language
Submitting author: @MiftariB
Handling editor: @fraukewiese (Active)
Reviewers: @odow, @leonardgoeke
Similarity score: 0.8022

Graph Transliterator: A graph-based transliteration tool
Submitting author: @seanpue
Handling editor: @gkthiruvathukal (Active)
Reviewers: @rlskoeser, @vc1492a
Similarity score: 0.7986

A flexible search system for high-accuracy identification of biological entities and molecules
Submitting author: @maxkfranz
Handling editor: @galessiorob (Active)
Reviewers: @AlexanderPico, @rabdill, @apcamargo
Similarity score: 0.7964

3dfier: automatic reconstruction of 3D city models
Submitting author: @hugoledoux
Handling editor: @arfon (Active)
Reviewers: @GANys, @chenkianwee
Similarity score: 0.7941

BigX: A geographical dataset visualisation tool
Submitting author: @geekysquirrel
Handling editor: @hugoledoux (Active)
Reviewers: @liberostelios, @jvdkwast
Similarity score: 0.7939

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

danielskatz commented Feb 9, 2024

👋 @PioBeat - thanks for your submission. Before we get started with the review, there are a couple of issues:

  1. Your paper is too long. JOSS has a normal upper limit of roughly 1000 words, and your paper is close to 2000. Please see the example paper for an example of a typical JOSS paper. You can use the command @editorialbot check repository to run checks on the repository that include the word count of the paper.

  2. In addition, please work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again.

Once you have made changes in the paper, whether this is content or references, please use the command @editorialbot generate pdf to make a new PDF.

editorialbot commands need to be the first entry in a new comment.

I'll put this on pause until you tell me it's ready to start because these two issues have been resolved.

Finally, regarding the other planned submission, since that hasn't yet happen, it doesn't matter to JOSS. But when you do submit that other paper, be sure to either mention or cite this paper, depending on its status, as I don't know the other journal's policy.

@PioBeat
Copy link

PioBeat commented Feb 12, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-030-43916-3 is OK
- 10.1007/978-3-319-75396-6_5 is OK
- 10.1007/3-540-44618-4_19 is OK
- 10.1007/978-3-540-31847-7_20 is OK
- 10.1142/9789812562494_0038 is OK
- 10.1007/3-540-31188-2 is OK
- 10.1007/978-3-030-51372-6_3 is OK
- 10.1016/j.dam.2018.07.006 is OK
- 10.1007/11841883_27 is OK
- 10.1109/VLHCC.2005.23 is OK
- 10.5445/IR/1000007369 is OK
- 10.4204/EPTCS.231.2 is OK
- 10.1007/978-3-662-45917-1_2 is OK
- 10.1016/j.entcs.2007.04.013 is OK
- 10.1007/s00165-011-0184-5 is OK
- 10.1007/978-3-642-03741-2_28 is OK
- 10.1007/978-3-319-41540-6_27 is OK
- 10.1007/978-3-540-89020-1_38 is OK

MISSING DOIs

- None

INVALID DOIs

- None

1 similar comment
@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-030-43916-3 is OK
- 10.1007/978-3-319-75396-6_5 is OK
- 10.1007/3-540-44618-4_19 is OK
- 10.1007/978-3-540-31847-7_20 is OK
- 10.1142/9789812562494_0038 is OK
- 10.1007/3-540-31188-2 is OK
- 10.1007/978-3-030-51372-6_3 is OK
- 10.1016/j.dam.2018.07.006 is OK
- 10.1007/11841883_27 is OK
- 10.1109/VLHCC.2005.23 is OK
- 10.5445/IR/1000007369 is OK
- 10.4204/EPTCS.231.2 is OK
- 10.1007/978-3-662-45917-1_2 is OK
- 10.1016/j.entcs.2007.04.013 is OK
- 10.1007/s00165-011-0184-5 is OK
- 10.1007/978-3-642-03741-2_28 is OK
- 10.1007/978-3-319-41540-6_27 is OK
- 10.1007/978-3-540-89020-1_38 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@PioBeat
Copy link

PioBeat commented Feb 12, 2024

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.05 s (894.5 files/s, 88515.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Java                            25            385            431           2045
Markdown                         2            164              0            462
TeX                              1             14              0            335
Maven                            1             10             17            294
XMI                             12              0              0            287
XML                              4              0              0            274
YAML                             1              1              4             18
JSON                             2              0              0              9
-------------------------------------------------------------------------------
SUM:                            48            574            452           3724
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1079

@PioBeat
Copy link

PioBeat commented Feb 12, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

A flexible search system for high-accuracy identification of biological entities and molecules
Submitting author: @maxkfranz
Handling editor: @galessiorob (Active)
Reviewers: @AlexanderPico, @rabdill, @apcamargo
Similarity score: 0.7963

GBOML: Graph-Based Optimization Modeling Language
Submitting author: @MiftariB
Handling editor: @fraukewiese (Active)
Reviewers: @odow, @leonardgoeke
Similarity score: 0.7956

3dfier: automatic reconstruction of 3D city models
Submitting author: @hugoledoux
Handling editor: @arfon (Active)
Reviewers: @GANys, @chenkianwee
Similarity score: 0.7933

Graph Transliterator: A graph-based transliteration tool
Submitting author: @seanpue
Handling editor: @gkthiruvathukal (Active)
Reviewers: @rlskoeser, @vc1492a
Similarity score: 0.7912

BigX: A geographical dataset visualisation tool
Submitting author: @geekysquirrel
Handling editor: @hugoledoux (Active)
Reviewers: @liberostelios, @jvdkwast
Similarity score: 0.7909

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@PioBeat
Copy link

PioBeat commented Feb 12, 2024

@danielskatz it's ready to start. The issues should be resolved.

@danielskatz
Copy link

👋 @Nikoleta-v3 - do you think you would be able to edit this submission?

@danielskatz
Copy link

@editorialbot invite @Nikoleta-v3 as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@danielskatz
Copy link

👋 @Nikoleta-v3 - pinging again - do you think you would be able to edit this submission?

@Nikoleta-v3
Copy link

Hello @danielskatz! My apologies for the delay. The last time I used Java was 8 years ago, so I'm not sure if I will be able to do justice to the submission 😅

@danielskatz
Copy link

👋 @AoifeHughes - Would you be able to edit this?

@danielskatz
Copy link

@editorialbot invite @AoifeHughes as editor

@vissarion
Copy link

Hi, @danielskatz, thanks for the invitation but my Java experience is very limited, so maybe there is a chance for a more suitable editor.

@danielskatz
Copy link

@vissarion - I wonder if this would be a place where you could depend on the reviewers, even without having so much Java experience?

@vissarion
Copy link

@danielskatz OK I can do that.

@vissarion
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @vissarion is now the editor

@vissarion
Copy link

👋 @maxkfranz, @MiftariB, @hugoledoux, @seanpue, @geekysquirrel, it seems that you are all interested in graph problems and algorithms, would any of you be willing to review this submission for JOSS?

@MiftariB
Copy link

MiftariB commented Mar 6, 2024

Thanks for the invitation. I will have to turn it down as my Java knowledge is too limited to properly review this article unfortunately.

@hugoledoux
Copy link

Same here, I'm afraid my Java knowledge is very very low, and I wouldn't be comfortable reviewing this.

@vissarion
Copy link

Hi @PioBeat do have any reviewers to recommend?

@maxkfranz
Copy link

👋 @maxkfranz, @MiftariB, @hugoledoux, @seanpue, @geekysquirrel, it seems that you are all interested in graph problems and algorithms, would any of you be willing to review this submission for JOSS?

It looks like an interesting tool, but I'll have to decline.

Since this tool is meant to pair with GrGen.NET, a Windows tool, I won't be able to review this. I don't have a Windows computer.

There's also a lot of Java environmental configuration and build setup here, and unfortunately, that would take up much more time than I have available right now. I strongly suggest adding a Dockerfile with verbatim docker run examples in the readme that work with the existing sample files. That would make it much more tractable for the future reviewers.

All the best with the search for reviewers.

@PioBeat
Copy link

PioBeat commented Mar 8, 2024

@maxkfranz If that helps you, GrGen.NET can be run under Linux with "monodevelop".
I think I will attempt to provide a Docker image. That would certainly make the review easier.

@vissarion Currently I do not have any reviewer in mind but I will think about that. Thanks for your help.

@abhishektiwari
Copy link

@vissarion I will be open to review this software paper. Feel free to add me as additional reviewer.

@vissarion
Copy link

@editorialbot add @abhishektiwari as reviewer

@editorialbot
Copy link
Collaborator Author

@abhishektiwari added to the reviewers list!

@vissarion
Copy link

Hi @Ethan-CS, @bencardoen, @LCB0B, @abhishektiwari, @fAndreuzzi would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@vissarion
Copy link

Hi @gabrielspadon, @sonal-raj, @camillescott, @Materials-Informatics-Laboratory, @idoby would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@idoby
Copy link

idoby commented Mar 15, 2024

Hi @gabrielspadon, @sonal-raj, @camillescott, @Materials-Informatics-Laboratory, @idoby would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Hi @vissarion. This isn't my forte but I can try to pretend to say something intelligent during the review. Please consider me as a reviewer but I also advise to try to bring in three reviewers if possible since I'm not confident about my ability to provide an insightful review here.

@Ethan-CS
Copy link

Ethan-CS commented Mar 15, 2024 via email

@vissarion
Copy link

@editorialbot add @Ethan-CS as reviewer

@editorialbot
Copy link
Collaborator Author

@Ethan-CS added to the reviewers list!

@vissarion
Copy link

@editorialbot add @idoby as reviewer

@editorialbot
Copy link
Collaborator Author

@idoby added to the reviewers list!

@vissarion
Copy link

Thank you all! I am starting the review thread now.

@vissarion
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6491.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java pre-review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests