-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: proteoDA: a package for quantitative proteomics #5184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
Howdy @shahmoradi and @MohmedSoudy! Thanks for agreeing to review this submission. The process for conducting a review is outlined above. Please run the command shown above to have @editorialbot generate your checklist, which will give a step-by-step process for conducting your review. Please check the boxes during your review to keep track, as well as make comments in this thread or open issues in the repository itself to point out issues you encounter. Keep in mind that our aim is to improve the submission to the point where it is of high enough quality to be accepted, rather than to provide a yes/no decision, and so having a conversation with the authors is encouraged rather than providing a single review post at the end of the process. Here are the review guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html Please let me know if you encounter any issues or need any help during the review process, and thanks for contributing your time to JOSS and the open source community! |
Review checklist for @MohmedSoudyConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @ByrumLab, Thank you for that great software package. The paper is well-written and the package is well-documented, however, I have some comments that may increase the package's feasibility and usability
|
HI @MohmedSoudy, Thank you for taking time to review our package.
We appreciate your time and helpful suggestions. |
@shahmoradi, do you think you'll have a chance to look at this submission soon? |
Apologies for my delayed response. I can respond as soon as I am back from an ongoing conference by this weekend if that is not too late. |
Review checklist for @MohmedSoudyConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @ByrumLab Thank you for addressing my comments. For me, the paper and the package now are ready and I think it's acceptable for publication. |
Review checklist for @shahmoradiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf |
I have a few comments for which I'd appreciate the authors' response before I mark the remaining items in the checklist as approved.
|
Thank you @shahmoradi, we appreciate the review! We've made some changes to the package in response to your review:
We hope these changes address your concerns. |
Hi @shahmoradi, I wanted to check if there are anymore concerns you would like us to address for this package? Thanks! |
Hi @shahmoradi, do you have any remaining concerns? If not, would you mind ticking the remaining boxes to let us know you're satisfied? Thanks! |
@shahmoradi can you please provide an update? |
Thank you for your response @ByrumLab. I am fine with the latest updates and improvements and have approved all items in the checklist. |
Great, thanks! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4262, then you can now move forward with accepting the submission by compiling again with the command |
I'm sorry @ByrumLab, I'm afraid I can't do that. That's something only eics are allowed to do. |
@ByrumLab @mikerobeson I checked the paper, the repository, and the archive link, and all seems in order. I did find a typo in the paper which you need to address:
|
Correcting the typo as referenced [here](openjournals/joss-reviews#5184 (comment)). Changed "reserchers" to "researchers".
Great catch @Kevin-Mattheus-Moerman! I just committed the fix. |
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@openjournals/dev this DOI is taking very long to resolve ☝️ |
Resolves now |
@ByrumLab congratulations on this publication in JOSS! Thanks for editing @jmschrei ! And a special thanks to the reviewers: @shahmoradi, @MohmedSoudy |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @ByrumLab (Stephanie D. Byrum)
Repository: https://github.com/ByrumLab/proteoDA
Branch with paper.md (empty if default branch): main
Version: 1.0.0
Editor: @jmschrei
Reviewers: @shahmoradi, @MohmedSoudy
Archive: 10.5281/zenodo.7962306
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@shahmoradi & @MohmedSoudy, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jmschrei know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @shahmoradi
The text was updated successfully, but these errors were encountered: