-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: Nuclear Morphology Analysis 2.0.0: Improved image analysis software for measuring nuclear shape #4767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Howdy @petebankhead and @suyashkumar! Thanks for agreeing to review this submission. The process for conducting a review is outlined above. Please run the command shown above to have @editorialbot generate your checklist, which will give a step-by-step process for conducting your review. Please check the boxes during your review to keep track, as well as make comments in this thread or open issues in the repository itself to point out issues you encounter. Keep in mind that our aim is to improve the submission to the point where it is of high enough quality to be accepted, rather than to provide a yes/no decision, and so having a conversation with the authors is encouraged rather than providing a single review post at the end of the process. Here are the review guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html Please let me know if you encounter any issues or need any help during the review process, and thanks for contributing your time to JOSS and the open source community! |
Review checklist for @petebankheadConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @suyashkumarConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I had no problems running the software, and the documentation seems very clear and extensive. Some minor points, relevant to the checklist above:
|
Thanks for the review @petebankhead! @bmskinner, let me know if there are any challenges addressing these points. |
Thanks @petebankhead for these comments! I have addressed them as follows:
The testing image zip file now has a readme file included with full details of the animals, suppliers, the licence under which they were collected, and the experimental protocol.
Thank you for this - the wiki has been updated, and the instructions will be included in the internal user guide in the next release.
Information on all dependencies have been added to a new wiki page (https://bitbucket.org/bmskinner/nuclear_morphology/wiki/Building_from_source.md)
There is no formal process at the moment, since it's just been me working on the code. I've added a note that external contributions are welcome though to the new build page and the FAQ, and potential contributors should contact me directly to discuss further.
Missing images have been added to the wiki. The internal user guide was not affected by this.
One of the dependencies is not in Maven Central, and this was only mentioned within the POM. I've added a new wiki page explaining the build process, and prerequisites (https://bitbucket.org/bmskinner/nuclear_morphology/wiki/Building_from_source.md). The build process has been checked on Windows and Linux; on MacOs, the jar with bundled dependencies should be generated, but I've not been able to test this.
The section has been expanded to give examples of existing software, and explain the methods in some more detail.
The citation has been updated as suggested. |
Thanks @bmskinner ! I can confirm the tests now run on macOS.
Do you know how I can access the updated version? |
@editorialbot generate pdf |
@petebankhead it should have triggered now! |
@suyashkumar how is the review coming? |
Hi @jmschrei thanks for following up--I expect to complete the rest of the review in the next 2 days. Apologies for the delay! |
Overall this looks good to me! I was able to run the prebuilt Linux software according to the installation instructions, run a test analysis, and run the full test suite successfully. I had only one very minor rubric-based recommendation, and a couple optional ones that are non-blocking suggestions. Minor Rubric-based recommendations
Optional General/Future Suggestions:
|
Thanks for the review @suyashkumar! @bmskinner, let me know if there are any challenges addressing these points. |
Thank you @suyashkumar for the feedback and suggestions!
I have added this to the FAQ, and to the internal user guide for future versions.
Links have been added as suggested
I have added a link to the installation page as suggested
This is a good suggestion, I've added a script to download and install the non-Maven dependency. The manual instructions are still on the wiki for those with non-standard local Maven repo paths.
Thanks for this - there is no formal process at the moment, since I'm the only developer, but I have added a contributions file to welcome prospective collaborators and get them to contact me directly.
This is also very useful to know and I will implement this if more developers join the project. |
Thanks @bmskinner! Looks good from my end 👍🏽 ! |
Great, thanks for the reviews! |
@editorialbot check references |
@jmschrei Sorry, I blatted the paper files when merging the changes back into the paper branch. All back now. |
Great. Do you have a DOI and a software version to tag this submission with? |
@jmschrei The repo is now on Zenodo: |
@editorialbot set 10.5281/zenodo.7303498 as archive |
Done! Archive is now 10.5281/zenodo.7303498 |
@editorialbot set 2.0.0 as version |
Done! version is now 2.0.0 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3699, then you can now move forward with accepting the submission by compiling again with the command |
@Kevin-Mattheus-Moerman just pinging you about this. |
@bmskinner I am the AEiC for this track and here to help process acceptance of this work in JOSS. I have just read your paper and inspected the archive and have the below remaining issues to address:
Let me know when you've worked on these. |
@editorialbot generate pdf |
@Kevin-Mattheus-Moerman I've made the following changes as requested:
The Zenodo title has been updated to match the paper title
The Zenodo license has been updated to GPL3
United Kingdom is now given in the affiliation
The sentence has been revised to Decomposing nuclear outlines into elliptic fourier descriptors is simpler and allows high-throughput analysis
Apologies, the missing figure file has been added back to the repository |
@bmskinner great, all looks good now and we shall proceed with the acceptance process. |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@bmskinner congratulations on this publication in JOSS!! Thanks for editing @jmschrei! And special thanks to @petebankhead and @suyashkumar for your review efforts!!!!!!!!!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @bmskinner (Ben Skinner)
Repository: https://bitbucket.org/bmskinner/nuclear_morphology
Branch with paper.md (empty if default branch): paper
Version: 2.0.0
Editor: @jmschrei
Reviewers: @petebankhead, @suyashkumar
Archive: 10.5281/zenodo.7303498
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@petebankhead & @suyashkumar, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jmschrei know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @petebankhead
📝 Checklist for @suyashkumar
The text was updated successfully, but these errors were encountered: