7904059: Enable alternative Runner instantiation and Main reuse #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third in a series of PRs that I will be sending over the next few days, which make extending JMH to benchmark Java code running as GraalVM native images more easily. The codename for this extension is Fibula. It can still work without this PRs but without them the extension has to duplicate code that exists in JMH, which is not desirable.
This PR refactors the main class to enable reuse of most of its logic, while allowing the construction of the
Runner
instance to be overridden by a subclass. An example of this override can be seen here.Here is the PR list for reference:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/161/head:pull/161
$ git checkout pull/161
Update a local copy of the PR:
$ git checkout pull/161
$ git pull https://git.openjdk.org/jmh.git pull/161/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 161
View PR using the GUI difftool:
$ git pr show -t 161
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/161.diff
Using Webrev
Link to Webrev Comment